cvs: php-master-web /fetch docsauth.php

goba Sun Jun 13 08:56:44 2004 EDT Modified files: /php-master-web/fetch docsauth.php Log: fix register_globals vulnerability and tabs to spaces http://cvs.php.net/diff.php/php-master-web/fetch/docsauth.php?r1=1.2&r2=1.3&ty=u Index: php-master-web/fetch/docsauth.php diff -u php-master-web/fetch/docsauth.php:1.2 php-master-web/fetch/docsauth.php:1.3 --- php-master-web/fetch/docsauth.php:1.2 Sun Jun 13 05:00:34 2004 +++ php-master-web/fetch/docsauth.php Sun Jun 13 08:56:44 2004 @@ -1,24 +1,27 @@ <?php -// $Id: docsauth.php,v 1.2 2004/06/13 09:00:34 jacques Exp $ +// $Id: docsauth.php,v 1.3 2004/06/13 12:56:44 goba Exp $ require_once 'cvs-auth.inc'; -$user = null; -$pw = null; +$user = $pw = null; +// Protect from register_globals vulnerability +if (isset($_GET['_SERVER']) || isset($_POST['_SERVER']) || isset($_COOKIE['_SERVER'])) { + die("ERR: Permission denied."); +} if ($_SERVER['REMOTE_ADDR'] != '81.57.253.132' && - md5($_GET['token']) != '97669cf8c9a1449eb2099ea6147d125697669cf8c9a1449eb2099ea6147d1256') { - die ("ERR: Permission denied."); + md5($_GET['token']) != '97669cf8c9a1449eb2099ea6147d125697669cf8c9a1449eb2099ea6147d1256') { + die("ERR: Permission denied."); } if (isset($_GET['credential'])) { - list($user, $pw) = explode(":", base64_decode($_GET['credential'])); + list($user, $pw) = explode(":", base64_decode($_GET['credential'])); } else { - die ("ERR: No credential passed."); + die("ERR: No credential passed."); } if (verify_password($user, $pw)) { - die ("OK"); + die("OK"); } else { - die ("ERR: Login failed."); + die("ERR: Login failed."); }