#30500 [Asn->Csd]: phpweb/cvs-php.php E_ALL fixes

ID: 30500 Updated by: goba@php.net Reported By: toni dot viemero at iki dot fi -Status: Assigned +Status: Closed Bug Type: Website problem Operating System: FreeBSD 5.3-RC1 PHP Version: 5.0.2 Assigned To: goba New Comment: Patch applied, thanks. Previous Comments: ------------------------------------------------------------------------ [2004-10-20 19:10:46] toni dot viemero at iki dot fi http://selfdestruct.net/misc/phpweb.diff.txt ------------------------------------------------------------------------ [2004-10-20 18:59:36] goba@php.net Would you please upload this patch somwhere, so that it does not wrap? I am unable to apply it this way. ------------------------------------------------------------------------ [2004-10-20 18:50:05] toni dot viemero at iki dot fi Description: ------------ cvs-php.php reports undefined index errors on form elements Here's the fix: --- cvs-php.php.orig Wed Oct 20 19:42:54 2004 +++ cvs-php.php Wed Oct 20 19:45:01 2004 @@ -289,12 +289,12 @@ <tr> <th class="subr">Full Name:</th> <td><input type="text" size="50" name="fullname" - class="max" value="<?php echo clean($_POST['fullname']);?>" /></td> + class="max" value="<?php if (isset($_POST['fullname'])) echo clean($_POST['fullname']);?>" /></td> </tr> <tr> <th class="subr">Email:</th> <td><input type="text" size="50" name="email" - class="max" value="<?php echo clean($_POST['email']);?>" /></td> + class="max" value="<?php if (isset($_POST['email'])) echo clean($_POST['email']);?>" /></td> </tr> <tr> <th class="subr">For what purpose do you require a CVS account:<br/ > @@ -314,17 +314,17 @@ </tr> <tr> <th class="subr">If your intended purpose is not in the list, <br>please state it here:</th> - <td><textarea cols="50" rows="5" name="realpurpose" class="max"><?php echo clean($_POST['realpurpose']);?></textarea></td> + <td><textarea cols="50" rows="5" name="realpurpose" class="max"><?php if (isset($_POST['realpurpose'])) echo clean($_POST['realpurpose']);?></textarea></td> </tr> <tr> <th class="subr">User ID:<br /> <small>(single word, lower case)</small></th> <td><input type="text" size="10" name="id" - class="max" value="<?php echo clean($_POST['id']);?>" /></td> + class="max" value="<?php if (isset($_POST['id'])) echo clean($_POST['id']);?>" /></td> </tr> <tr> <th class="subr">Requested Password:</th> <td><input type="password" size="10" name="password" - class="max" value="<?php echo clean($_POST['password']);?>" /></td> + class="max" value="<?php if (isset($_POST['password'])) echo clean($_POST['password']);?>" /></td> </tr> <tr> <th colspan="2"><input type="submit" value="Send Request" /></th> ------------------------------------------------------------------------ -- Edit this bug report at http://bugs.php.net/?id=30500&edit=1