Re: cvs: php-bugs-web /include functions.inc
| From: | Helgi Þormar | Date: | Sun, 05 Jun 2005 07:13:14 +0000 |
| Subject: | Re: cvs: php-bugs-web /include functions.inc | ||
| References: | 1 2 | Groups: | php.mirrors |
| Request: | Send a blank email to php-mirrors+get-28344@lists.php.net to get a copy of this message | ||
On Sun, 2005-06-05 at 16:42 +1000, mazzanet wrote:
> Helgi Þormar Þorbjörnsson wrote:
> > dufuz Sun Jun 5 01:26:31 2005 EDT
> >
> > Modified files:
> > /php-bugs-web/include functions.inc
> > Log:
> > Website, Doc, LiveDoc and System operation bugs don't need PHP
> version as per request #33247
> >
> > #Added the Irrelevant choice which only works with above mentioned
> categories.
> >
> >
>
> http://cvs.php.net/diff.php/php-bugs-web/include/functions.inc?r1=1.155&r2=1.156&ty=u
> > Index: php-bugs-web/include/functions.inc
> > diff -u php-bugs-web/include/functions.inc:1.155
> php-bugs-web/include/functions.inc:1.156
> > --- php-bugs-web/include/functions.inc:1.155 Fri Apr 22 09:17:37 2005
> > +++ php-bugs-web/include/functions.inc Sun Jun 5 01:26:30 2005
> > @@ -133,7 +133,16 @@
> >
> > function show_version_options($current,$default="")
> > {
> > - $versions = array("4.3.11", "4.3.10", "4.3.9",
> "4CVS-".date("Y-m-d")." (stable)", "5.0.4",
> "5.0.3",
> "5CVS-".date("Y-m-d")." (dev)");
> > + $versions = array(
> > + "4.3.11",
> > + "4.3.10",
> > + "4.3.9",
> > + "4CVS-".date("Y-m-d")." (stable)",
> > + "5.0.4",
> > + "5.0.3",
> > + "5CVS-".date("Y-m-d")." (dev)",
> > + "Irrelevant",
> > + );
>
>
> Maybe remove the , after "Irrelevant". :)
No, there is no need, it works with that extra comma and actually helps
prevent parse errors from happening if some person adds a new option at
the bottom, forgets to add the comma and to test and just commits, plus
there is no need to nitpick on such small thing when you look at the
rest of php-bugs-web ;)
- Helgi