cvs: php-bugs-web /include functions.inc
| From: | Hannes Magnusson | Date: | Sun, 07 Jan 2007 19:38:21 +0000 |
| Subject: | cvs: php-bugs-web /include functions.inc | ||
| Groups: | php.mirrors | ||
| Request: | Send a blank email to php-mirrors+get-33735@lists.php.net to get a copy of this message | ||
bjori Sun Jan 7 19:38:21 2007 UTC
Modified files:
/php-bugs-web/include functions.inc
Log:
Remove weird code causing XSS hole and all sorts of troubles
http://cvs.php.net/viewvc.cgi/php-bugs-web/include/functions.inc?r1=1.201&r2=1.202&diff_format=u
Index: php-bugs-web/include/functions.inc
diff -u php-bugs-web/include/functions.inc:1.201 php-bugs-web/include/functions.inc:1.202
--- php-bugs-web/include/functions.inc:1.201 Thu Jan 4 14:28:49 2007
+++ php-bugs-web/include/functions.inc Sun Jan 7 19:38:21 2007
@@ -150,10 +150,8 @@
echo "<option value=\"\">--Please Select--</option>\n";
while (list(,$v) = each($versions)) {
echo "<option", ($current == $v ? " selected" : ""),
">$v</option>\n";
- if ($current == $v) $use++;
}
- if (!$use && $current) echo "<option selected>$current</option>\n";
- echo "<option value=\"earlier\">Earlier? Upgrade
first!</option>\n";
+ echo "<option value=\"earlier\"", ($current == "earlier" ? "
selected" : ""), ">Earlier? Upgrade first!</option>\n";
}
function display_errors($errors)