cvs: php-bugs-web / bug.php bugs.sql bugstats.php lbugs.php search.php

jimw Mon Jan 28 19:17:41 2002 EDT Modified files: /php-bugs-web bug.php bugs.sql bugstats.php lbugs.php search.php Log: dev_id column wasn't being updated, and really isn't necessary, so get rid of it. Index: php-bugs-web/bug.php diff -u php-bugs-web/bug.php:1.19 php-bugs-web/bug.php:1.20 --- php-bugs-web/bug.php:1.19 Mon Jan 14 14:11:23 2002 +++ php-bugs-web/bug.php Mon Jan 28 19:17:40 2002 @@ -27,7 +27,7 @@ # fetch info about the bug into $bug $query = "SELECT id,bug_type,email,passwd,sdesc,ldesc," - . "php_version,php_os,status,ts1,ts2,dev_id,assign," + . "php_version,php_os,status,ts1,ts2,assign," . "UNIX_TIMESTAMP(ts1) AS submitted, UNIX_TIMESTAMP(ts2) AS modified," . "COUNT(bug=id) AS votes," . "SUM(reproduced) AS reproduced,SUM(tried) AS tried," @@ -89,7 +89,7 @@ $errors[] = "The username or password you supplied was incorrect."; } elseif (!($errors = incoming_details_are_valid($in))) { - $query = "UPDATE bugdb SET sdesc='$in[sdesc]',status='$in[status]', bug_type='$in[bug_type]', assign='$in[assign]', dev_id='$in[user]', php_version='$in[php_version]', php_os='$in[php_os]', ts2=NOW() WHERE id=$id"; + $query = "UPDATE bugdb SET sdesc='$in[sdesc]',status='$in[status]', bug_type='$in[bug_type]', assign='$in[assign]', php_version='$in[php_version]', php_os='$in[php_os]', ts2=NOW() WHERE id=$id"; $success = @mysql_query($query); if ($success && !empty($ncomment)) { $query = "INSERT INTO bugdb_comments (bug, email, ts, comment) VALUES ($id,'$user@php.net',NOW(),'$ncomment')"; Index: php-bugs-web/bugs.sql diff -u php-bugs-web/bugs.sql:1.3 php-bugs-web/bugs.sql:1.4 --- php-bugs-web/bugs.sql:1.3 Wed Jan 2 19:22:31 2002 +++ php-bugs-web/bugs.sql Mon Jan 28 19:17:40 2002 @@ -15,7 +15,6 @@ status varchar(16), ts1 datetime, # bug created date ts2 datetime, # bug last updated date - dev_id varchar(16),# developer who last commented assign varchar(16), passwd varchar(20),# user password PRIMARY KEY (id), Index: php-bugs-web/bugstats.php diff -u php-bugs-web/bugstats.php:1.8 php-bugs-web/bugstats.php:1.9 --- php-bugs-web/bugstats.php:1.8 Mon Jan 28 09:37:45 2002 +++ php-bugs-web/bugstats.php Mon Jan 28 19:17:40 2002 @@ -17,7 +17,7 @@ @mysql_select_db("php3") or die("unable to select database"); -$query = "SELECT status,dev_id,bug_type,email,php_version,php_os FROM bugdb"; +$query = "SELECT status,bug_type,email,php_version,php_os FROM bugdb"; if ($phpver > 0) { $query .= " WHERE SUBSTRING(php_version,1,1) = '$phpver'"; @@ -30,10 +30,6 @@ while($row=mysql_fetch_array($result)) { $bug_type['all'][$row[bug_type]]++; $status_str = strtolower($row['status']); - if ($status_str == 'closed' || $status_str == 'bogus') { - $closed_by[$row['dev_id']]++; - } - $bug_type[$status_str][$row[bug_type]]++; $bug_type[$status_str]['all']++; $email[$row[email]]++; @@ -160,20 +156,6 @@ echo "<tr bgcolor=#aabbcc><th align=right>Median life of a report:</th><td bgcolor=#ccddee>".ShowTime($median)."</td></tr>\n"; echo "<tr bgcolor=#aabbcc><th align=right>Slowest report closure:</th><td bgcolor=#ccddee>".ShowTime($row[slowest])."</td></tr>\n"; echo "<tr bgcolor=#aabbcc><th align=right>Quickest report closure:</th><td bgcolor=#ccddee>".ShowTime($row[quickest])."</td></tr>\n"; -echo "</table>\n"; - -echo "<p><b>Who is closing the bug reports?</b>\n"; -echo "<table>\n"; -arsort($closed_by); -$i=0; -while($i < 20) { - list($who,$value)=each($closed_by); - if (trim($who) == '') { - continue; - } - echo "<tr bgcolor=#aabbcc><th>$who</th><td bgcolor=#ccddee>$value</td></tr>\n"; - $i++; -} echo "</table>\n"; commonFooter(); Index: php-bugs-web/lbugs.php diff -u php-bugs-web/lbugs.php:1.3 php-bugs-web/lbugs.php:1.4 --- php-bugs-web/lbugs.php:1.3 Tue Nov 20 19:38:43 2001 +++ php-bugs-web/lbugs.php Mon Jan 28 19:17:40 2002 @@ -5,7 +5,7 @@ mysql_select_db("php3"); if ($id) { - $result = mysql_query("SELECT id,bug_type,email,sdesc,ldesc,php_version,php_os,status,ts1,dev_id,assign FROM bugdb WHERE id=$id"); + $result = mysql_query("SELECT id,bug_type,email,sdesc,ldesc,php_version,php_os,status,ts1,assign FROM bugdb WHERE id=$id"); if(!$result) { echo mysql_error(); exit; } if ($num = mysql_num_rows($result)) { $row = mysql_fetch_array($result); Index: php-bugs-web/search.php diff -u php-bugs-web/search.php:1.11 php-bugs-web/search.php:1.12 --- php-bugs-web/search.php:1.11 Fri Jan 4 22:13:14 2002 +++ php-bugs-web/search.php Mon Jan 28 19:17:40 2002 @@ -54,10 +54,6 @@ $where_clause .= " AND assign = '$assign'"; } - /* not in the header, but someone can build a query manually with it. */ - if(strlen($by) and $by!='Any') - $where_clause .= " AND dev_id = '$by' "; - $query .= "$where_clause "; /* we avoid adding an order by clause if using the full text search */