note 62691 added to function.phpversion

check_version have a logical error in the last line - it must return false. New check_version function: # Compares versions of software # versions must must use the format ' x.y.z... ' # where (x, y, z) are numbers in [0-9] function check_version($currentversion, $requiredversion) { list($majorC, $minorC, $editC) = split('[/.-]', $currentversion); list($majorR, $minorR, $editR) = split('[/.-]', $requiredversion); if ($majorC > $majorR) return true; if ($majorC < $majorR) return false; // same major - check ninor if ($minorC > $minorR) return true; if ($minorC < $minorR) return false; // and same minor if ($editC >= $editR) return true; return false; } Yaroslav I. Vorozhko ---- Server IP: 195.248.191.91 Probable Submitter: 212.26.134.237 (proxied: 85.202.226.248) ---- X-Spam-Status: No, hits=3.1 required=5.0 tests=DATE_MISSING,FROM_NO_LOWER autolearn=no version=2.64 ---- Manual Page -- http://www.php.net/manual/en/function.phpversion.php Edit -- http://master.php.net/note/edit/62691 Del: integrated -- http://master.php.net/note/delete/62691/integrated Del: useless -- http://master.php.net/note/delete/62691/useless Del: bad code -- http://master.php.net/note/delete/62691/bad+code Del: spam -- http://master.php.net/note/delete/62691/spam Del: non-english -- http://master.php.net/note/delete/62691/non-english Del: in docs -- http://master.php.net/note/delete/62691/in+docs Del: other reasons-- http://master.php.net/note/delete/62691 Reject -- http://master.php.net/note/reject/62691 Search -- http://master.php.net/manage/user-notes.php