note 79107 added to function.substr

If the last character you want to trim from a string is an escape char like "\n", make sure you only strip 1 char, not 2. I discovered this when my code building some javascript chopped off the final paren when I used $mainmenu = substr($mainmenu, 0, -2); instead of $mainmenu = substr($mainmenu, 0, -1); <?php $mainmenu = ''; foreach($menu as $value) { $pname = $value['pagename']; $parent = $value['parent']; $title = $value['menutitle']; $href = $pname . '.php'; switch ($parent) { case '': case 'index': $mainmenu .= "mymenu.addMenu(\"$pname\",\"<b>$title</b>\", \"$href\")\n"; break; default: $submenu .= "mymenu.addSubMenu(\"$parent\", \"$pname\", \"<b>$title</b>\", \"$href\")\n"; } } $mainmenu = substr($mainmenu, 0, -1); $submenu = substr($submenu, 0, -1); ?> ---- Server IP: 64.71.164.2 Probable Submitter: 67.171.92.21 ---- Manual Page -- http://www.php.net/manual/en/function.substr.php Edit -- https://master.php.net/note/edit/79107 Del: integrated -- https://master.php.net/note/delete/79107/integrated Del: useless -- https://master.php.net/note/delete/79107/useless Del: bad code -- https://master.php.net/note/delete/79107/bad+code Del: spam -- https://master.php.net/note/delete/79107/spam Del: non-english -- https://master.php.net/note/delete/79107/non-english Del: in docs -- https://master.php.net/note/delete/79107/in+docs Del: other reasons-- https://master.php.net/note/delete/79107 Reject -- https://master.php.net/note/reject/79107 Search -- https://master.php.net/manage/user-notes.php