note 110741 added to function.http-negotiate-language
| From: | justme | Date: | Thu, 29 Nov 2012 22:16:44 +0000 |
| Subject: | note 110741 added to function.http-negotiate-language | ||
| Groups: | php.notes | ||
| Request: | Send a blank email to php-notes+get-192206@lists.php.net to get a copy of this message | ||
@ Anonymous 03-Nov-2008 07:23
Your code:
<?php
// if $http_accept_language was left out, read it from the HTTP-Header
if ($http_accept_language == "auto") $http_accept_language =
$_SERVER['HTTP_ACCEPT_LANGUAGE'];
?>
assumes that HTTP_ACCEPT_LANGUAGE will be set, when, in fact, it is not usually set by non-browser
clients like cURL, bots, webcrawlers and therelike.
The code should be changed to:
<?php
// if $http_accept_language was left out, read it from the HTTP-Header
if ($http_accept_language == "auto")
$http_accept_language = isset($_SERVER['HTTP_ACCEPT_LANGUAGE']) ?
$_SERVER['HTTP_ACCEPT_LANGUAGE'] : "";
?>
----
Server IP: 69.147.83.199
Probable Submitter: 188.192.0.131
----
Manual Page -- http://www.php.net/manual/en/function.http-negotiate-language.php
Edit -- https://master.php.net/note/edit/110741
Del: integrated -- https://master.php.net/note/delete/110741/integrated
Del: useless -- https://master.php.net/note/delete/110741/useless
Del: bad code -- https://master.php.net/note/delete/110741/bad+code
Del: spam -- https://master.php.net/note/delete/110741/spam
Del: non-english -- https://master.php.net/note/delete/110741/non-english
Del: in docs -- https://master.php.net/note/delete/110741/in+docs
Del: other reasons-- https://master.php.net/note/delete/110741
Reject -- https://master.php.net/note/reject/110741
Search -- https://master.php.net/manage/user-notes.php