note 41820 deleted from ref.curl by betz

From: Date: Fri, 23 Apr 2004 08:34:11 +0000
Subject: note 41820 deleted from ref.curl by betz
References: 1  Groups: php.notes 
Request: Send a blank email to php-notes+get-68578@lists.php.net to get a copy of this message
Note Submitter: quentin.bennett.nospam at infinity co nz ---- I ran into this problem, and found the solution: On Fri, 26 Mar 2004, Vladimir Brajovic wrote: > Compiling ext/curl/curl.c fails because struct HttpPost is not declared. The > Curl change log indicates that '#define HttpPost curl_httppost' has been > removed from header file. However this seems to be causing this particular > problem since PHP still refers to HttpPost structure. By adding '#define > HttpPost curl_httppost' into curl.h, or by changing all references to > HttpPost in curl.c, I was able to eliminate this problem. The official API has been using curl_httppost for more than 2 years. I consider that enough time for everyone to move over. This change was also available in daily snapshots and the 7.11.1 pre-release in good time before the public release was made which should've given everyone who cared enough to test it. Not a single soul identified this as a problem before release. So, now everyone need to patch their *PHP source code*. The correct fix is to rename the structs in the PHP source code (or add the define in there). It is not to put back the define in the curl header. IMHO.

« previous php.notes (#68578) next »