note 56213 deleted from function.rmdir by betz
| From: | betz@php.net | Date: | Sat, 27 Aug 2005 10:07:51 +0000 |
| Subject: | note 56213 deleted from function.rmdir by betz | ||
| References: | 1 | Groups: | php.notes |
| Request: | Send a blank email to php-notes+get-94257@lists.php.net to get a copy of this message | ||
Note Submitter: Prismatik.net
Reason: bad code
----
Don't worry about how to delete a folder... and don't try anymore to snif through
sub-folders... This is THE TERRIBLE function!!:
- under UNIX:
$folder_to_delete = escapeshellarg($my_online_folder);
exec("rm -rf $folder_to_delete");
- under WINDOWS:
$folder_to_delete = escapeshellarg($my_online_folder);
exec("rmdir /s /q $folder_to_delete");
That's ALL!!
So, that means that from within one function, you must check the platform (unix or windows) by just
using a global variable only known by Windows: $WINDIR .
example:
function sendFolderInHell($my_online_folder){
$folder_to_delete = escapeshellarg($my_online_folder);
if(!isset($WINDIR)){
exec("rm -rf $folder_to_delete");
}else{
exec("rmdir /s /q $folder_to_delete");
}
}