Re: fix for PEAR bug #964, check before commit
| From: | Martin Jansen | Date: | Fri, 19 Mar 2004 08:35:02 +0000 |
| Subject: | Re: fix for PEAR bug #964, check before commit | ||
| References: | 1 | Groups: | php.pear.core |
| Request: | Send a blank email to pear-core+get-196@lists.php.net to get a copy of this message | ||
On Thu Mar 18, 2004 at 10:2625PM -0500, Greg Beaver wrote:
> I want to double check this patch before I commit it. Basically, it
> removes PEAR_ERROR_EXCEPTION without killing user uses of it, and
> removes documentation on it.
Unrelated to my previous mail, here is an attempt to fix the problem
in another way. It is written pretty much from the top of my head, so
I'm not sure, if it works out at all.
Instead of dropping PEAR_ERROR_EXCEPTION, a new (empty) class
Exception is introduced, from which PEAR_Error is a subclass.
Basically this results in:
if (!class_exists("Exception")) {
class Exception { }
}
class PEAR_Error extends Exception
{
...
This will surely add a bit of overhead to PEAR_Error, but actually
PEAR's error reporting infrastructure has never been canny concerning
CPU cycles, so I do not think this is much of a problem.
--
- Martin Martin Jansen
http://martinjansen.com/