cvs: php-src(PHP_4_3) /pear PEAR.php package-PEAR.xml

From: Date: Sat, 03 Apr 2004 06:28:52 +0000
Subject: cvs: php-src(PHP_4_3) /pear PEAR.php package-PEAR.xml
Groups: php.pear.cvs php.pear.core 
Request: Send a blank email to pear-core+get-212@lists.php.net to get a copy of this message
cellog Sat Apr 3 01:28:52 2004 EDT Modified files: (Branch: PHP_4_3) /php-src/pear PEAR.php package-PEAR.xml Log: MFH fix Bug #937 throwError() treats every call as static fix Bug #964 PEAR_ERROR_EXCEPTION causes fatal error http://cvs.php.net/diff.php/php-src/pear/PEAR.php?r1=1.50.2.17&r2=1.50.2.18&ty=u Index: php-src/pear/PEAR.php diff -u php-src/pear/PEAR.php:1.50.2.17 php-src/pear/PEAR.php:1.50.2.18 --- php-src/pear/PEAR.php:1.50.2.17 Thu Feb 26 21:27:12 2004 +++ php-src/pear/PEAR.php Sat Apr 3 01:28:46 2004 @@ -18,7 +18,7 @@ // | Tomas V.V.Cox <cox@idecnet.com> | // +----------------------------------------------------------------------+ // -// $Id: PEAR.php,v 1.50.2.17 2004/02/27 02:27:12 cellog Exp $ +// $Id: PEAR.php,v 1.50.2.18 2004/04/03 06:28:46 cellog Exp $ // define('PEAR_ERROR_RETURN', 1); @@ -26,6 +26,10 @@ define('PEAR_ERROR_TRIGGER', 4); define('PEAR_ERROR_DIE', 8); define('PEAR_ERROR_CALLBACK', 16); +/** + * WARNING: obsolete + * @deprecated + */ define('PEAR_ERROR_EXCEPTION', 32); define('PEAR_ZE2', (function_exists('version_compare') && version_compare(zend_version(), "2-dev", "ge"))); @@ -306,11 +310,11 @@ } switch ($mode) { + case PEAR_ERROR_EXCEPTION: case PEAR_ERROR_RETURN: case PEAR_ERROR_PRINT: case PEAR_ERROR_TRIGGER: case PEAR_ERROR_DIE: - case PEAR_ERROR_EXCEPTION: case null: $setmode = $mode; $setoptions = $options; @@ -549,7 +553,7 @@ $code = null, $userinfo = null) { - if (isset($this) && is_subclass_of($this, 'PEAR_Error')) { + if (isset($this) && is_a($this, 'PEAR')) { return $this->raiseError($message, $code, null, null, $userinfo); } else { return PEAR::raiseError($message, $code, null, null, $userinfo); @@ -774,8 +778,9 @@ call_user_func($this->callback, $this); } } - if (PEAR_ZE2 && $this->mode & PEAR_ERROR_EXCEPTION) { - eval('throw $this;'); + if ($this->mode & PEAR_ERROR_EXCEPTION) { + trigger_error("PEAR_ERROR_EXCEPTION is obsolete, use class PEAR_ErrorStack for exceptions", E_USER_WARNING); + eval('$e = new Exception($this->message, $this->code);$e->PEAR_Error = $this;throw($e);'); } } http://cvs.php.net/diff.php/php-src/pear/package-PEAR.xml?r1=1.28.2.33&r2=1.28.2.34&ty=u Index: php-src/pear/package-PEAR.xml diff -u php-src/pear/package-PEAR.xml:1.28.2.33 php-src/pear/package-PEAR.xml:1.28.2.34 --- php-src/pear/package-PEAR.xml:1.28.2.33 Sat Apr 3 01:09:27 2004 +++ php-src/pear/package-PEAR.xml Sat Apr 3 01:28:48 2004 @@ -55,6 +55,8 @@ * Bug #534 pear search doesn't list unstable releases * Bug #933 CMD Usability Patch + * Bug #937 throwError() treats every call as static + * Bug #964 PEAR_ERROR_EXCEPTION causes fatal error * Bug #1008 safe mode raises warning PEAR_ErrorStack:

« previous php.pear.core (#212) next »