Re: appending package state to filename

Looks like the uploader removes the -beta.tgz bit from the package name after uploading.. It's probably worth thinking about if it's worth modifying the pear.php.net to keep it or not. Regards Alan Alan Knowles wrote:

And to make it clearer when you install it.

--- /usr/share/pear/PEAR/Command/Install.php    2004-04-22 14:54:52.000000000 +0800
+++ /usr/src/php/php-src/pear/PEAR/Command/Install.php  2004-01-05 16:53:45.000000000 +0800

@@ -307,7 +307,7 @@

             $info = $this->installer->install($pkg['file'], $options, $this->config);
             if (is_array($info)) {
                 if ($this->config->get('verbose') > 0) {
-                    $label = "$info[package] $info[version] ($info[release_state])";
+                    $label = "$info[package] $info[version]";
                     $out = array('data' => "$command ok: $label");
                     if (isset($info['release_warnings'])) {
                         $out['release_warnings'] = $info['release_warnings'];

a Alan Knowles wrote:

As we chatted out before - below is a patch that adds the package state to the filename. rather than having to add it to the version number.. It's pretty easy to find in PEAR/Packager.php - function package() // {{{ TAR the Package -------------------------------------------

        $ext = $compress ? '.tgz' : '.tar';
        $dest_package = getcwd() . DIRECTORY_SEPARATOR . $pkgver . $ext;

// {{{ TAR the Package -------------------------------------------

        $ext = $compress ? '.tgz' : '.tar';
        $dest_package = getcwd() . DIRECTORY_SEPARATOR . $pkgver . '-' . $pkginfo['release_state'] . $ext;

I presume that the filename is not checked anywhere else in the pear system, so it shouldnt affect anything else.. Regards Alan

-- Can you help out? Need Consulting Services or Know of a Job? http://www.akbkhome.com