Re: cvs: pearweb /public_html/qa index.php
| From: | Klaus Guenther | Date: | Thu, 08 Jul 2004 11:33:00 +0000 |
| Subject: | Re: cvs: pearweb /public_html/qa index.php | ||
| References: | 1 | Groups: | php.pear.cvs php.pear.core |
| Request: | Send a blank email to pear-core+get-437@lists.php.net to get a copy of this message | ||
Could you clarify what you did here? It seems you put the wrong log entry on here. Thanks!
Klaus
Daniel Convissor wrote:
danielc Thu Jul 8 01:39:04 2004 EDTModified files: /pearweb/public_html/qa index.php Log:* Scripts mix $_GET['id'] and $id. So, in pepr.php, validate $_GET['id'] then assign $proposal->id to $pepr_id. If bogus proposal requested, set $pepr_id to 0. So, use $pepr_id in scripts for certainty of existance and purity. * Work with register_globals off. * Change DB::quote() to DB::quoteSmart() and ditch addslashes() and stripslashes() since that's handled by quoteSmart(). * htmlspecialchars() output. * In ppVote class, if get() produces no rows, return null. Eliminates PHP notices from bogus requests. * Fix "undefined offset" when looping through links when saving data in pepr-proposal-edit.php. The loop was getting the "url" from the next link. * Create $proposal object in pepr.php. * Create navigation tabs in pepr.php. * Don't send emails from DEVBOX. * Alter {owner_email} so mail() won't choke if owner email is blank. * Foramt like rest of pearweb, including error/warning formats. * Votes now viewed and entered via pepr-votes-show.php instead of pepr-proposal-show.php. * Comments now entered via pepr-comments-show.php instead of pepr-proposal-show.php. * Don't try to include things more than once. * Add page-level docblocks. * Only perform validate() if form submitted. * Show dates/times in UTC. * Provide warning * Eliminate undefined error in pepr-proposal-delete.php by changing $mapProposalStatus to $proposalStatiMap. * Provide warning to admins when trying to delete proposals after they leave the proposal stage. * Declare new Damblan_Karma() up front rather than in methods. NOTE: The two required links rules were not working, and continue not to, because they are looking at the "type" instead of the "url." http://cvs.php.net/diff.php/pearweb/public_html/qa/index.php?r1=1.5&r2=1.6&ty=u Index: pearweb/public_html/qa/index.php diff -u pearweb/public_html/qa/index.php:1.5 pearweb/public_html/qa/index.php:1.6 --- pearweb/public_html/qa/index.php:1.5 Mon Jul 5 16:22:35 2004 +++ pearweb/public_html/qa/index.php Thu Jul 8 01:39:04 2004 @@ -15,7 +15,7 @@ +----------------------------------------------------------------------+| Authors: Martin Jansen <mj@php.net> |+----------------------------------------------------------------------+ - $Id: index.php,v 1.5 2004/07/05 20:22:35 danielc Exp $ + $Id: index.php,v 1.6 2004/07/08 05:39:04 danielc Exp $ */ response_header("Quality Assurance Initiative"); ?> @@ -36,13 +36,13 @@ <?php - echo '<li>' . user_link('gurugeek') . "</li>\n"; - echo '<li>' . user_link('thesaur') . "</li>\n"; - echo '<li>' . user_link('arnaud') . "</li>\n"; - echo '<li>' . user_link('toby') . "</li>\n"; - echo '<li>' . user_link('schst') . "</li>\n"; - echo '<li>' . user_link('davey') . "</li>\n"; - echo '<li>' . user_link('lsmith') . "</li>\n"; + echo '<li>' . user_link('gurugeek', true) . "</li>\n"; + echo '<li>' . user_link('thesaur', true) . "</li>\n"; + echo '<li>' . user_link('arnaud', true) . "</li>\n"; + echo '<li>' . user_link('toby', true) . "</li>\n"; + echo '<li>' . user_link('schst', true) . "</li>\n"; + echo '<li>' . user_link('davey', true) . "</li>\n"; + echo '<li>' . user_link('lsmith', true) . "</li>\n"; ?>