cvs: php4 /pear/PEAR Common.php Packager.php

cox Mon Nov 5 19:22:18 2001 EDT Modified files: /php4/pear/PEAR Common.php Packager.php Log: E_ALL fixes Index: php4/pear/PEAR/Common.php diff -u php4/pear/PEAR/Common.php:1.21 php4/pear/PEAR/Common.php:1.22 --- php4/pear/PEAR/Common.php:1.21 Tue Oct 30 07:29:55 2001 +++ php4/pear/PEAR/Common.php Mon Nov 5 19:22:16 2001 @@ -18,7 +18,7 @@ // | | // +----------------------------------------------------------------------+ // -// $Id: Common.php,v 1.21 2001/10/30 12:29:55 ssb Exp $ +// $Id: Common.php,v 1.22 2001/11/06 00:22:16 cox Exp $ require_once 'PEAR.php'; require_once 'Archive/Tar.php'; @@ -147,7 +147,8 @@ { array_push($this->element_stack, $name); $this->current_element = $name; - $this->prev_element = $this->element_stack[sizeof($this->element_stack)-2]; + $spos = sizeof($this->element_stack) - 2; + $this->prev_element = ($spos >= 0) ? $this->element_stack[$spos] : ''; $this->current_attributes = $attribs; switch ($name) { case 'dir': @@ -253,7 +254,8 @@ $this->in_changelog = false; } array_pop($this->element_stack); - $this->current_element = $this->element_stack[sizeof($this->element_stack)-1]; + $spos = sizeof($this->element_stack) - 1; + $this->current_element = ($spos > 0) ? $this->element_stack[$spos] : ''; } // }}} @@ -265,48 +267,48 @@ case 'name': switch ($this->prev_element) { case 'package': - $this->pkginfo['package'] .= $data; + $this->pkginfo['package'] = $data; break; case 'maintainer': - $this->current_maintainer['name'] .= $data; + $this->current_maintainer['name'] = $data; break; } break; case 'summary': - $this->pkginfo['summary'] .= $data; + $this->pkginfo['summary'] = $data; break; case 'user': - $this->current_maintainer['handle'] .= $data; + $this->current_maintainer['handle'] = $data; break; case 'email': - $this->current_maintainer['email'] .= $data; + $this->current_maintainer['email'] = $data; break; case 'role': if (!in_array($data, $this->maintainer_roles)) { trigger_error("The maintainer role: '$data' is not valid", E_USER_WARNING); } else { - $this->current_maintainer['role'] .= $data; + $this->current_maintainer['role'] = $data; } break; case 'version': if ($this->in_changelog) { - $this->current_release['version'] .= $data; + $this->current_release['version'] = $data; } else { - $this->pkginfo['version'] .= $data; + $this->pkginfo['version'] = $data; } break; case 'date': if ($this->in_changelog) { - $this->current_release['release_date'] .= $data; + $this->current_release['release_date'] = $data; } else { - $this->pkginfo['release_date'] .= $data; + $this->pkginfo['release_date'] = $data; } break; case 'notes': if ($this->in_changelog) { - $this->current_release['release_notes'] .= $data; + $this->current_release['release_notes'] = $data; } else { - $this->pkginfo['release_notes'] .= $data; + $this->pkginfo['release_notes'] = $data; } break; case 'state': @@ -315,13 +317,12 @@ } elseif ($this->in_changelog) { $this->current_release['release_state'] = $data; } else { - $this->pkginfo['release_state'] .= $data; + $this->pkginfo['release_state'] = $data; } break; case 'dir': break; case 'file': - $role = strtolower($this->current_attributes['role']); $this->current_file = trim($data); break; case 'libname': Index: php4/pear/PEAR/Packager.php diff -u php4/pear/PEAR/Packager.php:1.19 php4/pear/PEAR/Packager.php:1.20 --- php4/pear/PEAR/Packager.php:1.19 Wed Oct 31 00:39:11 2001 +++ php4/pear/PEAR/Packager.php Mon Nov 5 19:22:18 2001 @@ -18,7 +18,7 @@ // | | // +----------------------------------------------------------------------+ // -// $Id: Packager.php,v 1.19 2001/10/31 05:39:11 ssb Exp $ +// $Id: Packager.php,v 1.20 2001/11/06 00:22:18 cox Exp $ require_once 'PEAR/Common.php'; @@ -114,7 +114,7 @@ } $pwd = getcwd(); $pkgfile = basename($pkgfile); - if ($pkginfo['release_state'] == 'snapshot') { + if (isset($pkginfo['release_state']) && $pkginfo['release_state'] == 'snapshot') { $pkginfo['version'] = date('Ymd'); } // don't want strange characters