Re: cvs: pear /Log_Parser Parser.php

On Wed, 2003-09-24 at 17:34, Xavier Noguer Gallego wrote: > - for ($i = 1; $i <= count($lineDef); $i++) { > - $this->_indexes[$lineName][$i] = > $config_array[$lineName][$i]['name']; > - $this->regex[$lineName] .= > $config_array[$lineName][$i]['pattern']; > + for ($i = 1; $i <= (count($lineDef)); $i++) { > + @$this->_indexes[$lineName][$i] = > @$config_array[$lineName][$i]['name']; > + @$this->regex[$lineName] .= > @$config_array[$lineName][$i]['pattern']; putting on everything a "@" fixes your problems? if you wan't to be sure that the array index exist, _use_ isset() not @ and putting a function call into the for condition is not good, the function (count()) is called on every cycle, if the value doesn't change, like in this case ($lineDef) it should call count() once and store it into a variable and then use the variable instead the functioncall.... This is just QA