Re: Modification of Package.php

El mar, 22-01-2002 a las 23:50, Vincent Blavet escribió: > The current Packager.php file is creating tar archive (.tgz) by using a temporary directory in > which it copies all the files before doing the archive. The temporary directory is not removed. I also realized that. I tracked down the problem and ended here: http://bugs.php.net/bug.php?id=14744 :-) > I did major changes in the Package.php file in order to improve that. Archive_Tar can be used > to directly read the files where they are and even add a 'virtual' path which is not the > real path of the files. > These changes will remove a lot of PHP code and will do less file copies. > > Because Packager.php is an important piece of the PEAR package downloading & installation, > I did not commit the change in php4/pear/PEAR. > > Can you please have a look to the modified file attached and tell me if I can proceed with the > commit ? > (BTW I did put in comment the code to remove in the attached file, but I will commit a cleaned > file). The changes looks pretty good, but I guess we shouldn't bypass certain checks. For example if the files in package.xml really exists. Other thing that should be kept is the ability to select different package files. For example this is supported now: PACK_DIR | +--package-v2.xml +--package-current.xml So you could maintain different package.xml files for different purpouses. For the rest and if works I'm all for it. Tomas V.V.Cox