cvs: pearweb /templates packages.html
| From: | Alan Knowles | Date: | Sun, 15 May 2005 05:48:58 +0000 |
| Subject: | cvs: pearweb /templates packages.html | ||
| Groups: | php.pear.cvs php.pear.core | ||
| Request: | Send a blank email to pear-cvs+get-31875@lists.php.net to get a copy of this message | ||
alan_k Sun May 15 01:48:58 2005 EDT
Modified files:
/pearweb/templates packages.html
Log:
this is such a bad way to use PHP, - its so unclear which part of the code is responsible for
cleaning and clensing the input/output. - remove another XSS attack
http://cvs.php.net/diff.php/pearweb/templates/packages.html?r1=1.21&r2=1.22&ty=u
Index: pearweb/templates/packages.html
diff -u pearweb/templates/packages.html:1.21 pearweb/templates/packages.html:1.22
--- pearweb/templates/packages.html:1.21 Wed Feb 23 01:33:05 2005
+++ pearweb/templates/packages.html Sun May 15 01:48:58 2005
@@ -217,7 +217,7 @@
Total number of packages: <?php echo $totalpackages; ?><br />
<?php make_link('/package-stats.php', 'View package statistics'); ?>
<?php else:?>
- <a href="/package-stats.php?cid=<?php echo $catpid; ?>">Statistics for
category "<?php echo $catname; ?>"</a>
+ <a href="/package-stats.php?cid=<?php echo $catpid; ?>">Statistics for
category "<?php echo htmlspecialchars($catname); ?>"</a>
<?php endif?>
</p>