cvs: pearweb /include pear-database.php
| From: | Martin Jansen | Date: | Fri, 14 Oct 2005 13:35:00 +0000 |
| Subject: | cvs: pearweb /include pear-database.php | ||
| Groups: | php.pear.cvs php.pear.core | ||
| Request: | Send a blank email to pear-cvs+get-35522@lists.php.net to get a copy of this message | ||
mj Fri Oct 14 09:35:00 2005 EDT
Modified files:
/pearweb/include pear-database.php
Log:
* Don't perform two queries where only is necessary when logging downloads.
http://cvs.php.net/diff.php/pearweb/include/pear-database.php?r1=1.294&r2=1.295&ty=u
Index: pearweb/include/pear-database.php
diff -u pearweb/include/pear-database.php:1.294 pearweb/include/pear-database.php:1.295
--- pearweb/include/pear-database.php:1.294 Thu Oct 13 06:42:37 2005
+++ pearweb/include/pear-database.php Fri Oct 14 09:34:58 2005
@@ -17,7 +17,7 @@
| Tomas V.V.Cox <cox@php.net> |
| Martin Jansen <mj@php.net> |
+----------------------------------------------------------------------+
- $Id: pear-database.php,v 1.294 2005/10/13 10:42:37 mj Exp $
+ $Id: pear-database.php,v 1.295 2005/10/14 13:34:58 mj Exp $
*/
require_once 'DB/storage.php';
@@ -2034,11 +2034,13 @@
// {{{ Update package_stats table
- // Check if an entry for the release already exists
- $query = "SELECT COUNT(pid) FROM package_stats WHERE pid = ? AND rid = ?";
- $exists = $dbh->getOne($query, array($package, $release_id));
+ $query = 'UPDATE package_stats '
+ . ' SET dl_number = dl_number + 1,'
+ . " last_dl = '" . date('Y-m-d H:i:s') . "'"
+ . ' WHERE pid = ? AND rid = ?';
+ $dbh->query($query, array($package, $release_id));
- if ($exists == 0) {
+ if ($dbh->affectedRows() == 0) {
$pkg_info = package::info($package, null);
$query = 'SELECT version FROM releases'
@@ -2062,12 +2064,6 @@
date('Y-m-d H:i:s')
)
);
- } else {
- $query = 'UPDATE package_stats '
- . ' SET dl_number = dl_number + 1,'
- . " last_dl = '" . date('Y-m-d H:i:s') .
"'"
- . ' WHERE pid = ? AND rid = ?';
- $dbh->query($query, array($package, $release_id));
}
// }}}