cvs: pear-core /tests/PEAR_Command_Config/config-create test.phpt test_windows.phpt
| From: | Greg Beaver | Date: | Thu, 20 Oct 2005 22:27:22 +0000 |
| Subject: | cvs: pear-core /tests/PEAR_Command_Config/config-create test.phpt test_windows.phpt | ||
| Groups: | php.pear.cvs php.pear.core | ||
| Request: | Send a blank email to pear-cvs+get-35747@lists.php.net to get a copy of this message | ||
cellog Thu Oct 20 18:27:22 2005 EDT
Modified files:
/pear-core/tests/PEAR_Command_Config/config-create test.phpt
test_windows.phpt
Log:
tests incorrectly assumed it should see a PEAR_Errors
and so were validating a non-working command!
http://cvs.php.net/diff.php/pear-core/tests/PEAR_Command_Config/config-create/test.phpt?r1=1.7&r2=1.8&ty=u
Index: pear-core/tests/PEAR_Command_Config/config-create/test.phpt
diff -u pear-core/tests/PEAR_Command_Config/config-create/test.phpt:1.7
pear-core/tests/PEAR_Command_Config/config-create/test.phpt:1.8
--- pear-core/tests/PEAR_Command_Config/config-create/test.phpt:1.7 Sat Sep 24 00:25:34 2005
+++ pear-core/tests/PEAR_Command_Config/config-create/test.phpt Thu Oct 20 18:27:22 2005
@@ -16,10 +16,7 @@
}
$e = $command->run('config-create', array(), array($temp_path2 . '/nomake',
$temp_path . DIRECTORY_SEPARATOR
. 'remote.ini'));
-$phpunit->assertErrors(array(
- array('package' => 'PEAR_Error', 'message' =>
'Configuration file "' .$temp_path . DIRECTORY_SEPARATOR .
- 'remote.ini" is empty')
-), 'log errors');
+$phpunit->assertNoErrors('log errors');
$phpunit->assertEquals(array (
0 =>
array (
http://cvs.php.net/diff.php/pear-core/tests/PEAR_Command_Config/config-create/test_windows.phpt?r1=1.7&r2=1.8&ty=u
Index: pear-core/tests/PEAR_Command_Config/config-create/test_windows.phpt
diff -u pear-core/tests/PEAR_Command_Config/config-create/test_windows.phpt:1.7
pear-core/tests/PEAR_Command_Config/config-create/test_windows.phpt:1.8
--- pear-core/tests/PEAR_Command_Config/config-create/test_windows.phpt:1.7 Sat Sep 24 00:25:34 2005
+++ pear-core/tests/PEAR_Command_Config/config-create/test_windows.phpt Thu Oct 20 18:27:22 2005
@@ -13,10 +13,7 @@
$temp_path2 = str_replace(DIRECTORY_SEPARATOR, '\\', $temp_path);
$e = $command->run('config-create', array('windows' => true),
array($temp_path2 . DIRECTORY_SEPARATOR . 'nomake', $temp_path . DIRECTORY_SEPARATOR
. 'remote.ini'));
-$phpunit->assertErrors(array(
- array('package' => 'PEAR_Error', 'message' =>
'Configuration file "' .$temp_path . DIRECTORY_SEPARATOR .
- 'remote.ini" is empty')
-), 'log errors');
+$phpunit->assertNoErrors('log errors');
$phpunit->assertEquals(array (
0 =>
array (