Re: cvs: pear /Spreadsheet_Excel_Writer/Writer Worksheet.php
| From: | Daniel Convissor | Date: | Fri, 18 Nov 2005 16:05:15 +0000 |
| Subject: | Re: cvs: pear /Spreadsheet_Excel_Writer/Writer Worksheet.php | ||
| References: | 1 | Groups: | php.pear.cvs |
| Request: | Send a blank email to pear-cvs+get-36365@lists.php.net to get a copy of this message | ||
Dear Xavier:
On Sat, Nov 12, 2005 at 03:33:54AM -0000, Xavier Noguer Gallego wrote:
> Modified files:
> /pear/Spreadsheet_Excel_Writer/Writer Worksheet.php
...
> + /*if (preg_match("/\#/", $url)) {
> + list($dir_long, $sheet) = split("\#", $url);
> + }
> + else {
> + $dir_long = $url;
> + }
> +
> if (isset($sheet)) {
> $link_type |= 0x08;
> $sheet_len = pack("V", strlen($sheet) + 0x01);
> $sheet = join("\0", split('', $sheet));
> $sheet .= "\0\0\0";
> - } else {
> + }
> + else {
> $sheet_len = '';
> $sheet = '';
> + }*/
Is that block meant to be commented out? If it is, tucking the /* and */
onto lines of existing code makes it hard to notice that the stuff is
commented out.
Also, you changed something that was CS compliant:
- } else {
to something that isn't:
+ }
+ else {
Thanks,
--Dan
--
T H E A N A L Y S I S A N D S O L U T I O N S C O M P A N Y
data intensive web and database programming
http://www.AnalysisAndSolutions.com/
4015 7th Ave #4, Brooklyn NY 11232 v: 718-854-0335 f: 718-854-0409