Re: cvs: pear /Spreadsheet_Excel_Writer/Writer Worksheet.php

> Dear Xavier: > > On Sat, Nov 12, 2005 at 03:33:54AM -0000, Xavier Noguer Gallego wrote: > > Modified files: > > /pear/Spreadsheet_Excel_Writer/Writer Worksheet.php > ... > > + /*if (preg_match("/\#/", $url)) { > > + list($dir_long, $sheet) = split("\#", $url); > > + } > > + else { > > + $dir_long = $url; > > + } > > + > > if (isset($sheet)) { > > $link_type |= 0x08; > > $sheet_len = pack("V", strlen($sheet) + 0x01); > > $sheet = join("\0", split('', $sheet)); > > $sheet .= "\0\0\0"; > > - } else { > > + } > > + else { > > $sheet_len = ''; > > $sheet = ''; > > + }*/ > > Is that block meant to be commented out? If it is, tucking the /* and */ > onto lines of existing code makes it hard to notice that the stuff is > commented out. I suggest you use this new fangled IDE I discovered: http://www.vim.org It has this great option of highlighting comments with a different color (my personal preference for comments is blue, it makes me feel unique and free of conventions) > Also, you changed something that was CS compliant: > - } else { > to something that isn't: > + } > + else { Done in cvs. > Thanks, > > --Dan