Re: Re: cvs: pear /Math_Derivative Derivative.php

On 2/17/06, bertrand Gugger <bertrand@toggg.com> wrote: > > Hannes Magnusson wrote: > >> Whole lot of this commit has nothing todo with PHP4, please keep > >> commit messages as clear and correct as possible :) > It is related to PHP4, the idea was colder's package does not really > need php5, then as such, is welcome by the some "still" only php4 pear > users. > Consider mathematicians are almost poor (for the money). Read the commit message again and read the commit it self. There are few changes there that have absolutly nothing to do with php4 compatability. Was just a friendly note asking him to note *all* changes in the commit message in the future. You all know my opinion on PEAR and PHP5 - but in this case it didn't have anything to do with anything. As long as PHP4 compatability doesnt restrain the package Im fine with it. > >> > >> Btw. you deleted "?>" at the end of the file... > > Etienne Kneuss wrote: > > colder Thu Feb 16 20:34:26 2006 UTC > > > > Modified files: > > /pear/Math_Derivative Derivative.php > > Log: > > Adds the ending ?> > No ! > It's perfectly right to withdraw them. > It's protecting you against unwanted blank output, > what fucks off headers. > Please, Etienne, set it back out. > My personal plan is to suppress them in any next commits I will do. Given that he didnt address this removal in his commit message I thought it was accidently removed - I prefer keeping closing tags in order, you don't, matter of opinion. Up to Etienne since the PEAR CS doesnt say anything about this afaik. > Do us some code, parsing a poor php4 compatible package giving > "private", "static" and all those object stuff only as (required by > pear) docbook indications so to transform the scripts in some "only > php5" things. Don't quite understand, do you what? - Hannes