Re: cvs: pear /Structures_DataGrid DataGrid.php

"Justin Patrin" wrote: > On 2/23/06, Olivier Guilyardi <olivierg@php.net> wrote: >> olivierg Thu Feb 23 14:08:34 2006 UTC >> >> Modified files: >> /pear/Structures_DataGrid DataGrid.php >> Log: >> Crafted the new fill() method and provided a (PHP5 only) BC fix for the deprecated public >> property >> >> > > :-( *That's* going to break all of my scripts.... (AFAIKnew ->renderer > was the preferred/documented/only way to access the renderer....at > least when I first started using SDG) Yeah, that's unfortunately an old documentation issue. The only really clean way was and is the following: $renderer =& $dg->getRenderer(); $renderer->doSomething(); We decided to go this way because we also refactored the DataSource and Renderer drivers -- with the goal of a clean OOP interface, and therefore this change was also needed. But it is only a PHP4 issue, for PHP5 there is BC fix from Olivier. And for PHP4, doing the needed changes in user scripts shouldn't take too much time -- I've already done it for my own scripts. Please also note that calling something like (e.g. with HTMLTable renderer) $renderer->setTableAttribute() is also deprecated in favor of the new options available in the renderers. (Of course, these set...() methods are still available and provide the old functionality.) Regards, Mark