Re: cvs: pear /Text_Wiki/doc test_Text_Wiki.php
| From: | bertrand Gugger | Date: | Mon, 27 Feb 2006 10:20:28 +0000 |
| Subject: | Re: cvs: pear /Text_Wiki/doc test_Text_Wiki.php | ||
| References: | 1 | Groups: | php.pear.cvs php.pear.cvs |
| Request: | Send a blank email to pear-cvs+get-38674@lists.php.net to get a copy of this message | ||
Del Elson wrote:
delatbabel Mon Feb 27 09:19:50 2006 UTCHowever, your constructor still does not work. If I do, with a $parser not 'Default' $wiki = & new Text_Wiki(null, $parser); instead of: $wiki = & Text_Wiki::singleton(null, $parser); Then it produces a parser missing some rules (the ones from Default). Also, as said, for esthetic reasons only, I would have like to have the parameters reversed in constructor as: Text_Wiki($parser = 'Default', $rules = null) it's possible just by analyzing count and types of arguments. Once it's fixed, I will revise the subpackages constructors. They will no more be needed, just maintained for BC reasons. A further bad aspect this "bug" reveals (then it's not so negative :) ) is that it says nothing in that case, just badly parse. Regards -- togggModified files: /pear/Text_Wiki/doc test_Text_Wiki.php Log:Fix for new parameter order in singleton. Thanks Del !