cvs: pear /Structures_DataGrid/DataGrid/Renderer HTMLTable.php

olivierg Wed Mar 1 22:42:35 2006 UTC Modified files: /pear/Structures_DataGrid/DataGrid/Renderer HTMLTable.php Log: Added comments, related to bogus Bug #6151 "Need to encode URL correctly in HTMLTable renderer" http://cvs.php.net/viewcvs.cgi/pear/Structures_DataGrid/DataGrid/Renderer/HTMLTable.php?r1=1.84&r2=1.85&diff_format=u Index: pear/Structures_DataGrid/DataGrid/Renderer/HTMLTable.php diff -u pear/Structures_DataGrid/DataGrid/Renderer/HTMLTable.php:1.84 pear/Structures_DataGrid/DataGrid/Renderer/HTMLTable.php:1.85 --- pear/Structures_DataGrid/DataGrid/Renderer/HTMLTable.php:1.84 Wed Mar 1 22:11:03 2006 +++ pear/Structures_DataGrid/DataGrid/Renderer/HTMLTable.php Wed Mar 1 22:42:35 2006 @@ -18,7 +18,7 @@ // | Mark Wiesemann <wiesemann@php.net> | // +----------------------------------------------------------------------+ // -// $Id: HTMLTable.php,v 1.84 2006/03/01 22:11:03 olivierg Exp $ +// $Id: HTMLTable.php,v 1.85 2006/03/01 22:42:35 olivierg Exp $ require_once 'Structures/DataGrid/Renderer/Common.php'; require_once 'HTML/Table.php'; @@ -56,7 +56,7 @@ * mb_internal_encoding(), otherwise it is ISO-8859-1 * * - * @version $Revision: 1.84 $ + * @version $Revision: 1.85 $ * @author Andrew S. Nagy <asnagy@webitecture.org> * @author Olivier Guilyardi <olivier@samalyse.com> * @author Mark Wiesemann <wiesemann@php.net> @@ -304,9 +304,12 @@ /** * Handles building the header of the DataGrid * + * This method use http_build_query() to build links. To customize the GET + * arguments separator please see the arg_separator.output php ini setting + * * @access protected * @return void - * @todo Redesign/Rework the header URL building. + * @see http://www.php.net/manual/en/function.http-build-query.php */ function buildHeader() { @@ -357,9 +360,14 @@ // Build Link URL $url = $this->_options['selfPath'] . '?'; - // Merge common and column-specific GET variables + /* Merge common and column-specific GET variables + * + * Note: users who want their GET parameters separated by + * "&amp;" instead of "&" (see Bug #6151) should properly + * configure the "arg_separator.output" php ini setting */ $url .= http_build_query(array_merge($common, $get)); + // Build HTML Link $str = "<a href=\"$url\">$label $icon</a>"; } else {