Re: cvs: php4 /pear PEAR.php

At 04:08 PM 8/4/2001 +0200, Thies C. Arntzen wrote:

On Sat, Aug 04, 2001 at 01:18:07PM +0200, Tomas V.V.Cox wrote: "Thies C. Arntzen" wrote:

On Sat, Aug 04, 2001 at 12:59:25PM +0200, Tomas V.V.Cox wrote:

"Thies C. Arntzen" wrote:

On Sat, Aug 04, 2001 at 10:47:10AM -0000, Thomas V.V.Cox wrote:

cox           Sat Aug  4 06:47:10 2001 EDT

Modified files:

    /php4/pear        PEAR.php

Log: don't show the call_user_method deprecated use warning

(disturbs tests)

Index: php4/pear/PEAR.php diff -u php4/pear/PEAR.php:1.10 php4/pear/PEAR.php:1.11 --- php4/pear/PEAR.php:1.10 Tue Jul 31 03:57:12 2001

+++ php4/pear/PEAR.php        Sat Aug  4 06:47:10 2001

@@ -17,7 +17,7 @@

 // |          Stig Bakken 

<ssb@fast.no> |

//

+----------------------------------------------------------------------+

// -// $Id: PEAR.php,v 1.10 2001/07/31 07:57:12 ssb Exp $ +// $Id: PEAR.php,v 1.11 2001/08/04 10:47:10 cox Exp $ // define('PEAR_ERROR_RETURN', 1); @@ -497,7 +497,7 @@

                       is_object($this->callback[0]) &&
                       is_string($this->callback[1]) &&
                       strlen($this->callback[1])) {
-                call_user_method($this->callback[1], 

$this->callback[0],

+ @call_user_method($this->callback[1],

$this->callback[0],

    wouldn't it make more sense to change this to
    call_user_func(array(&$this->callback[1],...) ?

I didn't know call_user_func() supports an array as it first param (at least not in the doc). From wich version?

    been a while - but it hasn't been mentioned in the NEWS file.
    but the change should be widely visible thru the notice
    call_user_method() throws;-)

Yeah :) The problem is if this change is very new or not. We had some problems with old php version incompatibilities and think that don't want to increase them :-) At least >= 4.0.4 should be supported.

    hmm, i do not see any reason why the pear that's in the php4
    tree should work against anything lower than the php it's
    bundled with.

    call_user_func with an array as the 1st paramter has been
    available since (from cvs log)

revision 1.334 date: 2001/05/14 19:02:23; author: sterling; state: Exp; lines: +78 -43 Couple of changes (and a little whitespace correction, sorry to mix :(

    1) Depreciate the call_user_method*() variety of functions, their
    functionality can be easily duplicated by using the call_user_func*()
    functions (using the array(&$obj, "method") syntax).

    2) Change some pval's to zval's.

    3) Improve the error handling mechanism of call_user_func*() to report
    an the class name and the function name if an object or class name is
    given.

    re,
    tc

    BTW: sterling, why didn't you create a NEWS entry for this
    one?

        I forgot ;-)

        I made the change without a NEWS entry, in case anyone objected, then I was going to add it, but never got around to it.

        -Sterling