cvs: pearweb / package.php /public_html/bugs bug.php

cellog Sun Feb 25 23:38:03 2007 UTC Modified files: /pearweb package.php /pearweb/public_html/bugs bug.php Log: implement Request #10180 require account to open/edit bugs, use auto-email verification like pear.voter http://cvs.php.net/viewvc.cgi/pearweb/package.php?r1=1.106&r2=1.107&diff_format=u Index: pearweb/package.php diff -u pearweb/package.php:1.106 pearweb/package.php:1.107 --- pearweb/package.php:1.106 Sun Feb 25 19:48:23 2007 +++ pearweb/package.php Sun Feb 25 23:38:03 2007 @@ -21,9 +21,11 @@ $a->setNotes(' * fix release upload: don\'t let custom non-pear built packages with no package.xml in root dir slip through the cracks +* fix Bug #10183: roadmap link to bug tracker needs &cmd=display * implement Request #10150: Allow "future" roadmap versions * implement Request #10176: patch tracker for bugs -* fix Bug #10183: roadmap link to bug tracker needs &cmd=display +* implement Request #10180: require account to open/edit bugs, + use auto-email verification like pear.voter '); $a->resetUsesrole(); $a->addUsesRole('web', 'Role_Web', 'pearified.com'); http://cvs.php.net/viewvc.cgi/pearweb/public_html/bugs/bug.php?r1=1.117&r2=1.118&diff_format=u Index: pearweb/public_html/bugs/bug.php diff -u pearweb/public_html/bugs/bug.php:1.117 pearweb/public_html/bugs/bug.php:1.118 --- pearweb/public_html/bugs/bug.php:1.117 Sun Feb 25 23:12:11 2007 +++ pearweb/public_html/bugs/bug.php Sun Feb 25 23:38:03 2007 @@ -15,7 +15,7 @@ * @package Bugs * @copyright Copyright (c) 1997-2005 The PHP Group * @license http://www.php.net/license/3_0.txt PHP License - * @version $Id: bug.php,v 1.117 2007/02/25 23:12:11 cellog Exp $ + * @version $Id: bug.php,v 1.118 2007/02/25 23:38:03 cellog Exp $ */ /* @@ -276,7 +276,7 @@ $_POST['PEAR_PW2'] = md5($_POST['PEAR_PW2']); } $salt = $buggie->addRequest($_POST['PEAR_USER'], - $_POST['in']['email'], $_POST['in']['reporter_name'], + $_POST['in']['commentemail'], $_POST['in']['comment_name'], $_POST['PEAR_PW'], $_POST['PEAR_PW2']); if (is_array($salt)) { $errors = $salt; @@ -1162,21 +1162,12 @@ echo urlencode($name) ?>&revision=latest"><?php echo clean($name) ?></a> (last revision <?php echo date('Y-m-d H:i:s', $revisions[0][0]) ?> by <?php echo $revisions[0][1] ?>)<br /><?php } // Display comments -if ($dbh->getOne('SELECT handle FROM bugdb WHERE id=?', array($id))) { - $query = 'SELECT c.id,c.email,c.comment,UNIX_TIMESTAMP(c.ts) AS added, c.reporter_name as comment_name, u.registered, - u.showemail, u.handle - FROM bugdb_comments c - LEFT JOIN users u ON u.email = c.email - WHERE c.bug = '.(int)$id.' - GROUP BY c.id ORDER BY c.ts'; -} else { - $query = 'SELECT c.id,c.email,c.comment,UNIX_TIMESTAMP(c.ts) AS added, c.reporter_name as comment_name, 1 as registered, - u.showemail, u.handle - FROM bugdb_comments c - LEFT JOIN users u ON u.email = c.email - WHERE c.bug = '.(int)$id.' - GROUP BY c.id ORDER BY c.ts'; -} +$query = 'SELECT c.id,c.email,c.comment,UNIX_TIMESTAMP(c.ts) AS added, c.reporter_name as comment_name, IF(c.handle <> "",u.registered,1) as registered, + u.showemail, u.handle + FROM bugdb_comments c + LEFT JOIN users u ON u.handle = c.handle + WHERE c.bug = '.(int)$id.' + GROUP BY c.id ORDER BY c.ts'; $res =& $dbh->query($query); if ($res) { while ($row =& $res->fetchRow(DB_FETCHMODE_ASSOC)) {