cvs: pear /MDB2 package.php package_fbsql.php package_ibase.php package_mssql.php package_mysql.php package_mysqli.php package_oci8.php
package_pgsql.php package_querysim.php package_sqlite.php /MDB2/MDB2/Driver/Manager Common.php ibase.php mysql.php mysqli.php oci8.php sqlite.php
/MDB2/tests MDB2_manager_testcase.php

quipo Sun Sep 23 18:46:05 2007 UTC Modified files: /pear/MDB2/MDB2/Driver/Manager Common.php ibase.php mysql.php mysqli.php oci8.php sqlite.php /pear/MDB2 package.php package_fbsql.php package_ibase.php package_mssql.php package_mysql.php package_mysqli.php package_oci8.php package_pgsql.php package_querysim.php package_sqlite.php /pear/MDB2/tests MDB2_manager_testcase.php Log: - fixed bug #12083: createTable() in the Manager module now returns MDB2_OK on success, as documented

http://cvs.php.net/viewvc.cgi/pear/MDB2/MDB2/Driver/Manager/Common.php?r1=1.66&r2=1.67&diff_format=u Index: pear/MDB2/MDB2/Driver/Manager/Common.php diff -u pear/MDB2/MDB2/Driver/Manager/Common.php:1.66 pear/MDB2/MDB2/Driver/Manager/Common.php:1.67 --- pear/MDB2/MDB2/Driver/Manager/Common.php:1.66 Sun Sep 9 13:47:36 2007 +++ pear/MDB2/MDB2/Driver/Manager/Common.php Sun Sep 23 18:46:04 2007 @@ -42,7 +42,7 @@ // | Author: Lukas Smith <smith@pooteeweet.org> | // +----------------------------------------------------------------------+ // -// $Id: Common.php,v 1.66 2007/09/09 13:47:36 quipo Exp $ +// $Id: Common.php,v 1.67 2007/09/23 18:46:04 quipo Exp $ // /** @@ -157,7 +157,7 @@ * Removes any formatting in an index name using the 'idxname_format' option * * @param string $idx string that containts name of anl index - * @return string name of the index with possible formatting removed + * @return string name of the index with eventual formatting removed * @access protected */ function _fixIndexName($idx) @@ -327,7 +327,11 @@ if (PEAR::isError($db)) { return $db; } - return $db->exec($query); + $result = $db->exec($query); + if (PEAR::isError($result)) { + return $result; + } + return MDB2_OK; } // }}} http://cvs.php.net/viewvc.cgi/pear/MDB2/MDB2/Driver/Manager/ibase.php?r1=1.105&r2=1.106&diff_format=u Index: pear/MDB2/MDB2/Driver/Manager/ibase.php diff -u pear/MDB2/MDB2/Driver/Manager/ibase.php:1.105 pear/MDB2/MDB2/Driver/Manager/ibase.php:1.106 --- pear/MDB2/MDB2/Driver/Manager/ibase.php:1.105 Sat Aug 11 15:37:55 2007 +++ pear/MDB2/MDB2/Driver/Manager/ibase.php Sun Sep 23 18:46:05 2007 @@ -42,7 +42,7 @@ // | Author: Lorenzo Alberton <l.alberton@quipo.it> | // +----------------------------------------------------------------------+ // -// $Id: ibase.php,v 1.105 2007/08/11 15:37:55 quipo Exp $ +// $Id: ibase.php,v 1.106 2007/09/23 18:46:05 quipo Exp $ require_once 'MDB2/Driver/Manager/Common.php'; @@ -165,8 +165,11 @@ NEW.' . $name . ' = GEN_ID('.$sequence_name.', 1); END'; $result = $db->exec($trigger_sql); + if (PEAR::isError($result)) { + return $result; + } $this->_silentCommit(); - return $result; + return MDB2_OK; } // }}} @@ -282,6 +285,7 @@ return $this->_makeAutoincrement($field_name, $name, 1); } } + return MDB2_OK; } // }}} http://cvs.php.net/viewvc.cgi/pear/MDB2/MDB2/Driver/Manager/mysql.php?r1=1.97&r2=1.98&diff_format=u Index: pear/MDB2/MDB2/Driver/Manager/mysql.php diff -u pear/MDB2/MDB2/Driver/Manager/mysql.php:1.97 pear/MDB2/MDB2/Driver/Manager/mysql.php:1.98 --- pear/MDB2/MDB2/Driver/Manager/mysql.php:1.97 Sun Sep 9 12:58:33 2007 +++ pear/MDB2/MDB2/Driver/Manager/mysql.php Sun Sep 23 18:46:05 2007 @@ -42,7 +42,7 @@ // | Author: Lukas Smith <smith@pooteeweet.org> | // +----------------------------------------------------------------------+ // -// $Id: mysql.php,v 1.97 2007/09/09 12:58:33 quipo Exp $ +// $Id: mysql.php,v 1.98 2007/09/23 18:46:05 quipo Exp $ // require_once 'MDB2/Driver/Manager/Common.php'; @@ -211,7 +211,11 @@ if (!empty($options_strings)) { $query .= ' '.implode(' ', $options_strings); } - return $db->exec($query); + $result = $db->exec($query); + if (PEAR::isError($result)) { + return $result; + } + return MDB2_OK; } // }}} http://cvs.php.net/viewvc.cgi/pear/MDB2/MDB2/Driver/Manager/mysqli.php?r1=1.84&r2=1.85&diff_format=u Index: pear/MDB2/MDB2/Driver/Manager/mysqli.php diff -u pear/MDB2/MDB2/Driver/Manager/mysqli.php:1.84 pear/MDB2/MDB2/Driver/Manager/mysqli.php:1.85 --- pear/MDB2/MDB2/Driver/Manager/mysqli.php:1.84 Sun Sep 9 12:58:33 2007 +++ pear/MDB2/MDB2/Driver/Manager/mysqli.php Sun Sep 23 18:46:05 2007 @@ -42,7 +42,7 @@ // | Author: Lukas Smith <smith@pooteeweet.org> | // +----------------------------------------------------------------------+ // -// $Id: mysqli.php,v 1.84 2007/09/09 12:58:33 quipo Exp $ +// $Id: mysqli.php,v 1.85 2007/09/23 18:46:05 quipo Exp $ // require_once 'MDB2/Driver/Manager/Common.php'; @@ -211,7 +211,11 @@ if (!empty($options_strings)) { $query .= ' '.implode(' ', $options_strings); } - return $db->exec($query); + $result = $db->exec($query); + if (PEAR::isError($result)) { + return $result; + } + return MDB2_OK; } // }}} http://cvs.php.net/viewvc.cgi/pear/MDB2/MDB2/Driver/Manager/oci8.php?r1=1.93&r2=1.94&diff_format=u Index: pear/MDB2/MDB2/Driver/Manager/oci8.php diff -u pear/MDB2/MDB2/Driver/Manager/oci8.php:1.93 pear/MDB2/MDB2/Driver/Manager/oci8.php:1.94 --- pear/MDB2/MDB2/Driver/Manager/oci8.php:1.93 Sat Aug 11 15:37:55 2007 +++ pear/MDB2/MDB2/Driver/Manager/oci8.php Sun Sep 23 18:46:05 2007 @@ -42,7 +42,7 @@ // | Author: Lukas Smith <smith@pooteeweet.org> | // +----------------------------------------------------------------------+ -// $Id: oci8.php,v 1.93 2007/08/11 15:37:55 quipo Exp $ +// $Id: oci8.php,v 1.94 2007/09/23 18:46:05 quipo Exp $ require_once 'MDB2/Driver/Manager/Common.php'; @@ -204,7 +204,11 @@ END IF; END; '; - return $db->exec($trigger_sql); + $result = $db->exec($trigger_sql); + if (PEAR::isError($result)) { + return $result; + } + return MDB2_OK; } // }}} http://cvs.php.net/viewvc.cgi/pear/MDB2/MDB2/Driver/Manager/sqlite.php?r1=1.70&r2=1.71&diff_format=u Index: pear/MDB2/MDB2/Driver/Manager/sqlite.php diff -u pear/MDB2/MDB2/Driver/Manager/sqlite.php:1.70 pear/MDB2/MDB2/Driver/Manager/sqlite.php:1.71 --- pear/MDB2/MDB2/Driver/Manager/sqlite.php:1.70 Wed Aug 15 07:47:53 2007 +++ pear/MDB2/MDB2/Driver/Manager/sqlite.php Sun Sep 23 18:46:05 2007 @@ -43,7 +43,7 @@ // | Lorenzo Alberton <l.alberton@quipo.it> | // +----------------------------------------------------------------------+ // -// $Id: sqlite.php,v 1.70 2007/08/15 07:47:53 quipo Exp $ +// $Id: sqlite.php,v 1.71 2007/09/23 18:46:05 quipo Exp $ // require_once 'MDB2/Driver/Manager/Common.php'; @@ -355,7 +355,10 @@ } } } - return $result; + if (PEAR::isError($result)) { + return $result; + } + return MDB2_OK; } // }}} http://cvs.php.net/viewvc.cgi/pear/MDB2/package.php?r1=1.267&r2=1.268&diff_format=u Index: pear/MDB2/package.php diff -u pear/MDB2/package.php:1.267 pear/MDB2/package.php:1.268 --- pear/MDB2/package.php:1.267 Sun Sep 23 18:27:42 2007 +++ pear/MDB2/package.php Sun Sep 23 18:46:05 2007 @@ -20,6 +20,8 @@ - fixed bug #11975: Extended::autoExecute() does not work with Oracle when using LOBs (patch by Pieter Meulen, van der) - fixed some E_STRICT errors with PHP5 +- fixed bug #12083: createTable() in the Manager module now returns MDB2_OK on success, + as documented open todo items: - handle autoincrement fields in alterTable() http://cvs.php.net/viewvc.cgi/pear/MDB2/package_fbsql.php?r1=1.54&r2=1.55&diff_format=u Index: pear/MDB2/package_fbsql.php diff -u pear/MDB2/package_fbsql.php:1.54 pear/MDB2/package_fbsql.php:1.55 --- pear/MDB2/package_fbsql.php:1.54 Sun Sep 23 17:24:32 2007 +++ pear/MDB2/package_fbsql.php Sun Sep 23 18:46:05 2007 @@ -42,6 +42,8 @@ - migrated to package.xml version 2 - added _mapNativeDatatype() in the Datatype module - fixed bug #11790: avoid array_diff() because it has a memory leak in PHP 5.1.x +- fixed bug #12083: createTable() in the Manager module now returns MDB2_OK on success, + as documented note: - this driver needs a serious update as it's currently unmaintained/untested http://cvs.php.net/viewvc.cgi/pear/MDB2/package_ibase.php?r1=1.129&r2=1.130&diff_format=u Index: pear/MDB2/package_ibase.php diff -u pear/MDB2/package_ibase.php:1.129 pear/MDB2/package_ibase.php:1.130 --- pear/MDB2/package_ibase.php:1.129 Sun Sep 23 18:27:42 2007 +++ pear/MDB2/package_ibase.php Sun Sep 23 18:46:05 2007 @@ -10,6 +10,8 @@ - fixed bug #11428: propagate quote() errors with invalid data types - fixed bug #11790: avoid array_diff() because it has a memory leak in PHP 5.1.x - fixed some E_STRICT errors with PHP5 +- fixed bug #12083: createTable() in the Manager module now returns MDB2_OK on success, + as documented EOT; $description = 'This is the Interbase/Firebird MDB2 driver.'; http://cvs.php.net/viewvc.cgi/pear/MDB2/package_mssql.php?r1=1.96&r2=1.97&diff_format=u Index: pear/MDB2/package_mssql.php diff -u pear/MDB2/package_mssql.php:1.96 pear/MDB2/package_mssql.php:1.97 --- pear/MDB2/package_mssql.php:1.96 Sun Sep 23 17:24:32 2007 +++ pear/MDB2/package_mssql.php Sun Sep 23 18:46:05 2007 @@ -14,6 +14,8 @@ - fixed bug #11790: avoid array_diff() because it has a memory leak in PHP 5.1.x - request #11797: don't use mssql_field_name() in listTableFields() in the Manager module since it only returns the first 30 chars +- fixed bug #12083: createTable() in the Manager module now returns MDB2_OK on success, + as documented open todo items: - explore fast limit/offset emulation (Request #4544) http://cvs.php.net/viewvc.cgi/pear/MDB2/package_mysql.php?r1=1.123&r2=1.124&diff_format=u Index: pear/MDB2/package_mysql.php diff -u pear/MDB2/package_mysql.php:1.123 pear/MDB2/package_mysql.php:1.124 --- pear/MDB2/package_mysql.php:1.123 Sun Sep 23 18:27:42 2007 +++ pear/MDB2/package_mysql.php Sun Sep 23 18:46:05 2007 @@ -16,6 +16,8 @@ - fixed bug #11590: _getServerCapabilities() has to be called once per connection - fixed bug #11790: avoid array_diff() because it has a memory leak in PHP 5.1.x - fixed some E_STRICT errors with PHP5 +- fixed bug #12083: createTable() in the Manager module now returns MDB2_OK on success, + as documented note: - the multi_query test failes because this is not supported by ext/mysql http://cvs.php.net/viewvc.cgi/pear/MDB2/package_mysqli.php?r1=1.127&r2=1.128&diff_format=u Index: pear/MDB2/package_mysqli.php diff -u pear/MDB2/package_mysqli.php:1.127 pear/MDB2/package_mysqli.php:1.128 --- pear/MDB2/package_mysqli.php:1.127 Sun Sep 23 18:27:42 2007 +++ pear/MDB2/package_mysqli.php Sun Sep 23 18:46:05 2007 @@ -17,6 +17,8 @@ - fixed bug #11590: _getServerCapabilities() has to be called once per connection - fixed bug #11790: avoid array_diff() because it has a memory leak in PHP 5.1.x - fixed some E_STRICT errors with PHP5 +- fixed bug #12083: createTable() in the Manager module now returns MDB2_OK on success, + as documented open todo items: - use a trigger to emulate setting default now() http://cvs.php.net/viewvc.cgi/pear/MDB2/package_oci8.php?r1=1.131&r2=1.132&diff_format=u Index: pear/MDB2/package_oci8.php diff -u pear/MDB2/package_oci8.php:1.131 pear/MDB2/package_oci8.php:1.132 --- pear/MDB2/package_oci8.php:1.131 Sun Sep 23 18:27:42 2007 +++ pear/MDB2/package_oci8.php Sun Sep 23 18:46:05 2007 @@ -20,6 +20,8 @@ - fixed bug #11933: avoid duplicate queries in the Reverse module and free results and prepared statement handles (thanks Jan Reitz) - fixed some E_STRICT errors with PHP5 +- fixed bug #12083: createTable() in the Manager module now returns MDB2_OK on success, + as documented note: - please use the latest ext/oci8 version from pecl.php.net/oci8 http://cvs.php.net/viewvc.cgi/pear/MDB2/package_pgsql.php?r1=1.125&r2=1.126&diff_format=u Index: pear/MDB2/package_pgsql.php diff -u pear/MDB2/package_pgsql.php:1.125 pear/MDB2/package_pgsql.php:1.126 --- pear/MDB2/package_pgsql.php:1.125 Sun Sep 23 18:27:42 2007 +++ pear/MDB2/package_pgsql.php Sun Sep 23 18:46:05 2007 @@ -20,6 +20,8 @@ - fixed bug #11753: NOTICEs in alterTable() in the Manager module - fixed bug #11790: avoid array_diff() because it has a memory leak in PHP 5.1.x - fixed some E_STRICT errors with PHP5 +- fixed bug #12083: createTable() in the Manager module now returns MDB2_OK on success, + as documented open todo items: - enable pg_execute() once issues with bytea column are resolved http://cvs.php.net/viewvc.cgi/pear/MDB2/package_querysim.php?r1=1.47&r2=1.48&diff_format=u Index: pear/MDB2/package_querysim.php diff -u pear/MDB2/package_querysim.php:1.47 pear/MDB2/package_querysim.php:1.48 --- pear/MDB2/package_querysim.php:1.47 Tue Dec 5 12:31:02 2006 +++ pear/MDB2/package_querysim.php Sun Sep 23 18:46:05 2007 @@ -9,6 +9,8 @@ open todo items: - add ability to reference multiple results set files for different queries - phpdoc fixes +- fixed bug #12083: createTable() in the Manager module now returns MDB2_OK on success, + as documented EOT; $description = 'This is the Querysim MDB2 driver.'; http://cvs.php.net/viewvc.cgi/pear/MDB2/package_sqlite.php?r1=1.100&r2=1.101&diff_format=u Index: pear/MDB2/package_sqlite.php diff -u pear/MDB2/package_sqlite.php:1.100 pear/MDB2/package_sqlite.php:1.101 --- pear/MDB2/package_sqlite.php:1.100 Sun Sep 23 17:24:32 2007 +++ pear/MDB2/package_sqlite.php Sun Sep 23 18:46:05 2007 @@ -12,6 +12,8 @@ for PRIMARY KEYs and FOREIGN KEYs - fixed bug #11428: propagate quote() errors with invalid data types - fixed bug #11790: avoid array_diff() because it has a memory leak in PHP 5.1.x +- fixed bug #12083: createTable() in the Manager module now returns MDB2_OK on success, + as documented note: open todo items: http://cvs.php.net/viewvc.cgi/pear/MDB2/tests/MDB2_manager_testcase.php?r1=1.59&r2=1.60&diff_format=u Index: pear/MDB2/tests/MDB2_manager_testcase.php diff -u pear/MDB2/tests/MDB2_manager_testcase.php:1.59 pear/MDB2/tests/MDB2_manager_testcase.php:1.60 --- pear/MDB2/tests/MDB2_manager_testcase.php:1.59 Tue Aug 14 15:13:59 2007 +++ pear/MDB2/tests/MDB2_manager_testcase.php Sun Sep 23 18:46:05 2007 @@ -42,7 +42,7 @@ // | Lorenzo Alberton <l dot alberton at quipo dot it> | // +----------------------------------------------------------------------+ // -// $Id: MDB2_manager_testcase.php,v 1.59 2007/08/14 15:13:59 quipo Exp $ +// $Id: MDB2_manager_testcase.php,v 1.60 2007/09/23 18:46:05 quipo Exp $ require_once 'MDB2_testcase.php'; @@ -77,6 +77,7 @@ if (!$this->tableExists($this->table)) { $result = $this->db->manager->createTable($this->table, $this->fields); $this->assertFalse(PEAR::isError($result), 'Error creating table'); + $this->assertEquals(MDB2_OK, $result, 'Invalid return value for createTable()'); } }