Re: cvs: pear /PhpDocumentor pear-phpdoc phpdoc
| From: | Gregory Beaver | Date: | Sat, 29 Sep 2007 22:47:54 +0000 |
| Subject: | Re: cvs: pear /PhpDocumentor pear-phpdoc phpdoc | ||
| References: | 1 | Groups: | php.pear.cvs |
| Request: | Send a blank email to pear-cvs+get-48709@lists.php.net to get a copy of this message | ||
Chuck Burgess wrote:
> ashnazg Sat Sep 29 22:34:22 2007 UTC
>
> Modified files:
> /pear/PhpDocumentor phpdoc pear-phpdoc
> Log:
> PEAR CS cleanup
>
>
> http://cvs.php.net/viewvc.cgi/pear/PhpDocumentor/phpdoc?r1=1.4&r2=1.5&diff_format=uۀ>Q
>
> Index: pear/PhpDocumentor/phpdoc
> diff -u pear/PhpDocumentor/phpdoc:1.4 pear/PhpDocumentor/phpdoc:1.5
> --- pear/PhpDocumentor/phpdoc:1.4 Thu Jun 28 18:19:35 2007
> +++ pear/PhpDocumentor/phpdoc Sat Sep 29 22:34:22 2007
[snip]
> -$test = @include("phpDocumentor/find_phpdoc.php");
> -if ($test == 6) // find_phpdoc.php returns 6
> -{
> - include("phpDocumentor/phpdoc.inc");
> -} else
> -{
> +$test = @require "phpDocumentor/find_phpdoc.php";
Hi Chuck,
This change is incorrect, include was the correct method. If you use
require, the user will simply get a fatal error. phpcs isn't always the
smartest thing...
Greg