Re: cvs: pear /Validate/tests email.phpt

Actually these tests should pass when (if?) IDN support goes in, wonder if it should not be "YES" so that it doesn't get forgotten. Or am I misunderstanding something, at least how I saw it with IDN both username and domain name could be non ascii, or will it only be the domain name ? Or can the username be non ascii as it is ? Okey now I've confused my self :o Regards Helgi On Dec 11, 2007 4:31 AM, David Coallier <davidc@php.net> wrote: > davidc Tue Dec 11 04:31:44 2007 UTC > > Modified files: > /pear/Validate/tests email.phpt > Log: > - Tests with ????? were bogus, removed them. > - Removed the domain check (We know it works according to the first test) > > > > > http://cvs.php.net/viewvc.cgi/pear/Validate/tests/email.phpt?r1=1.11&r2=1.12&diff_format=u > Index: pear/Validate/tests/email.phpt > diff -u pear/Validate/tests/email.phpt:1.11pear/Validate/tests/email.phpt: > 1.12 > --- pear/Validate/tests/email.phpt:1.11 Sun Jun 17 09:32:29 2007 > +++ pear/Validate/tests/email.phpt Tue Dec 11 04:31:43 2007 > @@ -2,7 +2,7 @@ > email.phpt: Unit tests for > --FILE-- > <?php > -// $Id: email.phpt,v 1.11 2007/06/17 09:32:29 amir Exp $ > +// $Id: email.phpt,v 1.12 2007/12/11 04:31:43 davidc Exp $ > // Validate test script > $noYes = array('NO', 'YES'); > require 'Validate.php'; > @@ -12,7 +12,6 @@ > $emails = array( > // Try dns lookup > array('pear-general@lists.php.net', true), // OK > - array('example@fluffffffrefrffrfrfrfrfrfr.is', true), // NOK > array('example@fluffffffrefrffrfrfrfrfrfr.is', false), // OK > // with out the dns lookup > 'example@fluffffffrefrffrfrfrfrfrfr.is', // OK > @@ -22,8 +21,8 @@ > 'bugme@not./com', // OK > > // Some none english chars, those should fail until we fix the IDN > stuff > - 'hæjjæ@homms.com', // OK > - 'þæöð@example.com', // OK > + 'hæjjæ@homms.com', // NOK > + 'þæöð@example.com', // NOK > 'postmaster@tüv.de <postmaster@t%C3%BCv.de>', // NOK > > // Test for various ways with _ > @@ -109,14 +108,13 @@ > --EXPECT-- > Test Validate_Email > pear-general@lists.php.net: with domain check : YES > -example@fluffffffrefrffrfrfrfrfrfr.is: with domain check : NO > example@fluffffffrefrffrfrfrfrfrfr.is: without domain check : YES > example@fluffffffrefrffrfrfrfrfrfr.is: YES > davidc@php.net: YES > example (though bad)@example.com: YES > bugme@not./com: YES > -hæjjæ@homms.com: YES > -þæöð@example.com: YES > +hæjjæ@homms.com: NO > +þæöð@example.com: NO > postmaster@tüv.de <postmaster@t%C3%BCv.de>: NO > mark_@example.com: YES > _mark@example.com: YES > > -- > PEAR CVS Mailing List (http://pear.php.net/) > To unsubscribe, visit: http://www.php.net/unsub.php > >