cvs: pear /Net_SMTP SMTP.php
| From: | Jon Parise | Date: | Mon, 11 Feb 2008 03:00:34 +0000 |
| Subject: | cvs: pear /Net_SMTP SMTP.php | ||
| Groups: | php.pear.cvs | ||
| Request: | Send a blank email to pear-cvs+get-50978@lists.php.net to get a copy of this message | ||
jon Mon Feb 11 03:00:34 2008 UTC
Modified files:
/pear/Net_SMTP SMTP.php
Log:
When authenticating using the DIGEST-MD5 mechanism, we use an empty answer
to the last 334 response code because the SMTP protocol doesn't allow
subsequent authentication.
However, we were sending ' ' (a space) instead of '' (empty string), which
may have been causing problems with some SMTP servers and causing them to
return a 501 or 535 authentication failure code.
This change may solve the problems some folks have been seeing. Even if
it doesn't, it's a small improvement over the previous code and shouldn't
make things any worse.
Bug: 12206
http://cvs.php.net/viewvc.cgi/pear/Net_SMTP/SMTP.php?r1=1.60&r2=1.61&diff_format=u
Index: pear/Net_SMTP/SMTP.php
diff -u pear/Net_SMTP/SMTP.php:1.60 pear/Net_SMTP/SMTP.php:1.61
--- pear/Net_SMTP/SMTP.php:1.60 Tue Oct 30 18:14:16 2007
+++ pear/Net_SMTP/SMTP.php Mon Feb 11 03:00:33 2008
@@ -18,7 +18,7 @@
// | Damian Alejandro Fernandez Sosa <damlists@cnba.uba.ar> |
// +----------------------------------------------------------------------+
//
-// $Id: SMTP.php,v 1.60 2007/10/30 18:14:16 chagenbu Exp $
+// $Id: SMTP.php,v 1.61 2008/02/11 03:00:33 jon Exp $
require_once 'PEAR.php';
require_once 'Net/Socket.php';
@@ -573,7 +573,7 @@
/* We don't use the protocol's third step because SMTP doesn't
* allow subsequent authentication, so we just silently ignore
* it. */
- if (PEAR::isError($error = $this->_put(' '))) {
+ if (PEAR::isError($error = $this->_put(''))) {
return $error;
}
/* 235: Authentication successful */