Re: svn: /pear/packages/Bugtracker/trunk/include/classes/ bug_accountrequest.php

Greg Beaver wrote:

Felipe Ribeiro wrote:

felipernb                                Sun, 02 Aug 2009 21:07:07 +0000

Revision: http://svn.php.net/viewvc?view=revision&revision=286698 Log: Removing confirmRequest, a function that isn't called from anywhere Changed paths:

    U   pear/packages/Bugtracker/trunk/include/classes/bug_accountrequest.php

Modified: pear/packages/Bugtracker/trunk/include/classes/bug_accountrequest.php =================================================================== --- pear/packages/Bugtracker/trunk/include/classes/bug_accountrequest.php 2009-08-02 20:49:20 UTC (rev 286697) +++ pear/packages/Bugtracker/trunk/include/classes/bug_accountrequest.php 2009-08-02 21:07:07 UTC (rev 286698) @@ -134,8 +134,12 @@

         if (PEAR::isError($res)) {
             return $res;
         }

-

-        $this->handle = $this->dbh->prepare('SELECT handle FROM bug_account_request WHERE salt=?')->execute(array($salt))->fetchOne();

+ $stmt = $this->dbh->prepare('SELECT handle FROM bug_account_request WHERE salt=?'); + $res = $stmt->execute(array($salt)); + + if(!PEAR::isError($res))

+        	$this->handle = $stmt->fetchOne();

+

         return $salt;

Hi, Jani: since when is the stuff for PEAR's bug account removed from the tracker?

If it was unused, it was, I didn't check. In general: Yes, it should all be removed, bugs must be able to be reported without any damn accounts. :) And we already have common auth for all having svn accounts, so devs don't need this either. --Jani