svn: /pear/packages/Bugtracker/trunk/site/ bug.php
| From: | Jani Taskinen | Date: | Thu, 13 Aug 2009 12:32:48 +0000 |
| Subject: | svn: /pear/packages/Bugtracker/trunk/site/ bug.php | ||
| Groups: | php.pear.cvs | ||
| Request: | Send a blank email to pear-cvs+get-57109@lists.php.net to get a copy of this message | ||
jani Thu, 13 Aug 2009 12:32:48 +0000
Revision: http://svn.php.net/viewvc?view=revision&revision=287221
Log:
- Fix issues with previews. And no need to show the controls for previews!
Changed paths:
U pear/packages/Bugtracker/trunk/site/bug.php
Modified: pear/packages/Bugtracker/trunk/site/bug.php
===================================================================
--- pear/packages/Bugtracker/trunk/site/bug.php 2009-08-13 12:22:34 UTC (rev 287220)
+++ pear/packages/Bugtracker/trunk/site/bug.php 2009-08-13 12:32:48 UTC (rev 287221)
@@ -10,6 +10,10 @@
if ($_REQUEST['id'] == 'preview') {
$bug_id = 'PREVIEW';
$bug = $_SESSION['bug_preview'];
+ $bug['submitted'] = time();
+ $bug['modified'] = null;
+ $bug['votes'] = 0;
+ $bug['assign'] = '';
if (!$bug) {
header('Location: index.php');
@@ -457,11 +461,11 @@
response_header(
"{$bug_type} #{$bug_id} :: " . htmlspecialchars($bug['sdesc']),
- "
+ ($bug_id != 'PREVIEW') ? "
<link rel='alternate' type='application/rss+xml'
title='{$bug['package_name']} Bug #{$bug['id']} - RDF'
href='rss/bug.php?id={$bug_id}' />
<link rel='alternate' type='application/rss+xml'
title='{$bug['package_name']} Bug #{$bug['id']} - RSS 2.0'
href='rss/bug.php?id={$bug_id}&format=rss2' />
<script type='text/javascript' src='js/util.js'></script>
- "
+ " : ''
);
// DISPLAY BUG
@@ -516,6 +520,7 @@
<th class="details">Modified:</th>
<td style="white-space: nowrap;"><?php echo ($bug['modified']) ?
format_date($bug['modified']) : '-'; ?></td>
<td rowspan="5">
+
<?php if ($bug['votes']) { ?>
<table id="votes">
<tr><th class="details">Votes:</th><td><?php echo
$bug['votes'] ?></td></tr>
@@ -554,6 +559,8 @@
</table>
</div>
+<?php if ($bug_id != 'PREVIEW') { ?>
+
<div class="controls">
<?php
control(0, 'View');
@@ -620,6 +627,8 @@
<br clear="all" />
<?php }
+} // if ($bug_id != 'PREVIEW') {
+
//
// FIXME! Do not wrap here either. Re-use the comment display function!
//
@@ -895,25 +904,30 @@
}
// Display patches
-require_once "{$ROOT_DIR}/include/classes/bug_patchtracker.php";
-$patches = new Bug_Patchtracker;
-$p = $patches->listPatches($bug_id);
-?>
+if ($bug_id != 'PREVIEW') {
+ require_once "{$ROOT_DIR}/include/classes/bug_patchtracker.php";
+ $patches = new Bug_Patchtracker;
+ $p = $patches->listPatches($bug_id);
+
+ echo "<h2>Patches</h2>\n";
-<h2>Patches</h2>
-<?php
+ foreach ($p as $name => $revisions)
+ {
+ $obsolete = $patches->getObsoletingPatches($bug_id, $name, $revisions[0][0]);
+ $style = !empty($obsolete) ? ' style="background-color: yellow; text-decoration:
line-through;" ' : '';
+ $url_name = urlencode($name);
+ $clean_name = clean($name);
+ $formatted_date = format_date($revisions[0][0]);
-foreach ($p as $name => $revisions)
-{
- $obsolete = $patches->getObsoletingPatches($bug_id, $name, $revisions[0][0]);
- $style = !empty($obsolete) ? ' style="background-color: yellow; text-decoration:
line-through;" ' : '';
-?><a href="patch-display.php?bug_id=<?php echo $bug_id; ?>&patch=<?php
echo urlencode($name) ?>&revision=latest" <?php echo $style; ?>>
-<?php echo clean($name) ?></a> (last revision <?php echo
format_date($revisions[0][0]) ?> by <?php echo $revisions[0][1] ?>)<br /><?php
echo "\n";
+ echo <<< OUTPUT
+<a
href="patch-display.php?bug_id={$bug_id}&patch={$url_name}&revision=latest"
{$style}>{$clean_name}</a>
+(last revision {$formatted_date}) by {$revisions[0][1]})
+<br />
+OUTPUT;
+ }
+ echo "<p><a href='patch-add.php?bug_id={$bug_id}'>Add a
Patch</a></p>";
}
-?><p><a href="patch-add.php?bug_id=<?php echo $bug_id; ?>">Add a
Patch</a></p>
-<?php
-
// Display comments
$bug_comments = bugs_get_bug_comments($bug_id);
if (is_array($bug_comments) && count($bug_comments)) {