RE: [PEAR-DEV] fixing MDB's file structure
| From: | Lukas Smith | Date: | Thu, 17 Oct 2002 15:38:01 +0000 |
| Subject: | RE: [PEAR-DEV] fixing MDB's file structure | ||
| References: | 1 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-10111@lists.php.net to get a copy of this message | ||
> From: Stig S. Bakken [mailto:ssb@fast.no]
> Sent: Thursday, October 17, 2002 5:12 PM
> To: Lukas Smith
> Cc: 'PHP PEAR Developer'
> Subject: Re: [PEAR-DEV] fixing MDB's file structure
>
> On Thu, 2002-10-17 at 13:30, Lukas Smith wrote:
> > Hi,
> >
> > I need someone with enough power to help me fix the MDB file
structure.
> > It supposed to be similar to PEAR DB.
> > I have modified the package.xml already to what it is supposed to
be.
>
> The package.xml file looks fine, but I'm a bit uncertain about how to
> deal with the "tools" directory. The way it's structured now, they
will
> end up in $php_dir/tools/metabase_wrapper.php etc. What's your intent
> with these files, how should they be used? Maybe MDB/tools is the
right
> destination for these?
Ups, yes that is what I wanted (MDB/tools)
> > BTW: I have one question there.
> > Should the unittest's be under the directory 'unittest' or the more
> > general 'test' or do people even give a rats ass?
>
> "unittest" is fine, since the tests you define there are not common
> .phpt files, but PHPUnit-based tests. Right?
>
> I'm too busy at work to contribute to PHP and PEAR right now, some
time
> next week things should start cooling down and I can catch up my mail
> again.
>
Ok I think it should probably be named 'unittests' (with an 's' at the
end) to be more in line with 'tests'.
I sort of blindly copied everything from DB.
These tests usually go into one common test directory.
So where should they do for PHPUnit tests?
1) $php_dir/unittests/
2) or MDB/unittests
In case we want a single 'unittests' dir I guess we should define a
naming scheme as well has a method to define how conf files should be
handled etc.
But all in all 2) probably makes the most sense?
> I'm too busy at work to contribute to PHP and PEAR right now, some
time
> next week things should start cooling down and I can catch up my mail
> again.
Hmm, does anyone else have the necessary permissions to handle this?
I would really like to make a new release this weekend. But if all else
fails I can of course wait.
Regards,
Lukas