Re: [PATCH] Log/syslog.php fix

On Fri, Oct 25, 2002 at 05:41:15PM -0400, Andres Salomon wrote: > Log.php encourages a default value of '' for $name in Log's constructor; > however, if passed along to Log/syslog.php's constructor, openlog() > gives an error about expecting an integer instead of a string. So, this > patch sets Log_syslog::_name to LOG_SYSLOG, if it's not set. I'd also > suggest some type checking here (if (!is_int($name) || > $is_int($maxLevel)) return false), but that's less of an issue here. Good point. I've just committed a slightly modified version of your patch. Thanks! -- Jon Parise (jon@php.net) :: The PHP Project (http://www.php.net/)