#15423 [Csd]: HTTP::negotiateLanguage() severely bugged.

ID: 15423 User updated by: vigna@acm.org Reported By: vigna@acm.org Status: Closed Bug Type: PEAR related Operating System: Linux Red Hat 7.2 PHP Version: 4.1.1 Assigned To: mj New Comment: Nothing has changed: the bug is still there. Previous Comments: ------------------------------------------------------------------------ [2002-02-17 13:53:08] vigna@acm.org The bug in the regexp is still there: '^([a-z]+);[[:space:]]*q=([0-9\.]+)' Unless I'm *really* missing something, this will not accept, say, en-US from the browser. Another problem is the last part of the function: guessing the language from the domain should at least be given as an option. I think, for instance, to german-speaking people in Italy, which are very proud of speaking German and would be irritated and frustrated by a site giving content in Italian just because of their .it extension. ------------------------------------------------------------------------ [2002-02-11 08:08:42] mj@php.net I fixed the outstanding issue in CVS. The documentation will be updated around tomorrow. ------------------------------------------------------------------------ [2002-02-07 06:22:33] vigna@acm.org Is it possible to get CVS access? It did that some time ago, but now I cannot find a pointer in the PEAR site. The problem with "_" is that Linux uses that for locales. But an HTTP language negotiation should IMHO return the HTTP language, not some system-specific counterpart. The user has just to do a strtr if necessary. Better fix it now than breaking other code later... ------------------------------------------------------------------------ [2002-02-07 06:18:42] mj@php.net The first two problems have been fixed in CVS. I also think, that we can easily change the problem with the language code, but I would like to hear the opinion of the package maintainers. - Martin ------------------------------------------------------------------------ [2002-02-07 05:36:42] vigna@acm.org The code for HTTP::negotiateLanguage() is severely bugged. At line 76 of HTTP.php, $HTTP_ACCEPT_LANGUAGE is accessed without having been declarated global. Thus negotiation always happens on the empty string (a warning is generated). At line 102 $HTTP_SERVER_VARS['REMOTE_HOST'] is accessed without checking for existence of the key, causing a warning. The example stated in the documentation above the function uses "_" to separate language and country. The HTTP RFC uses "-". The regexp used to parse the header has neither. The default value ("en_US") suffers from the same problem--it does not respect the RFC. ------------------------------------------------------------------------ -- Edit this bug report at http://bugs.php.net/?id=15423&edit=1