#21402 [Opn->Csd]: Critical bug in PEAR::Archive_Tar

ID: 21402 Updated by: vblavet@php.net Reported By: jmcastagnetto@php.net -Status: Open +Status: Closed Bug Type: PEAR related Operating System: Solaris 8 PHP Version: 4.3.0 -Assigned To: +Assigned To: vblavet New Comment: This bug has been fixed in CVS. In case this was a PHP problem, snapshots of the sources are packaged every three hours; this change will be in the next snapshot. You can grab the snapshot at http://snaps.php.net/. In case this was a documentation problem, the fix will show up soon at http://www.php.net/manual/. In case this was a PHP.net website problem, the change will show up on the PHP.net site and on the mirror sites in short time. Thank you for the report, and for helping us make PHP better. The last CVS of Archive_Tar (pear/Archive_Tar/Archive/Tar.php) correct this bug. However this does not change the limitation of filename length. Previous Comments: ------------------------------------------------------------------------ [2003-01-03 19:24:09] jmcastagnetto@php.net There seems to be a problem in line 658 of Tar.php: if (strlen($v_stored_filename) > 99) { $this->_warning("Stored file name is too long (max. 99) : '$v_stored_filename'"); fclose($v_file); return true; } The "$v_file" var is not defined anywhere before that line in the _addFile() method. Trying to generate a tarball release from a phpDocumentor snapshot (phpdoc-20030102.tar.gz from http://developer.phpdoc.org/downloads/), generated the following notices and warnings (many repeated lines): % pear package ... Notice: Undefined variable: v_file in Tar.php on line 658 Warning: fclose(): supplied argument is not a valid stream resource in Tar.php on line 658 ... Notice: Undefined variable: v_file in Tar.php on line 658 Warning: fclose(): supplied argument is not a valid stream resource in Tar.php on line 658 Package /tmp/phpdoc/PhpDocumentor-1.2.0beta1.tgz done The tarball created is clearly fubared, because trying to do an install just bombs again: % pear install PhpDocumentor-1.2.0beta1.tgz warning : bad md5sum for file /export/dredox1/devel_server/php/lib/php/phpDocumentor/phpDocumentor/Converter.inc warning : bad md5sum for file /export/dredox1/devel_server/php/lib/php/phpDocumentor/phpDocumentor/DescHTML.inc warning : bad md5sum for file /export/dredox1/devel_server/php/lib/php/phpDocumentor/phpDocumentor/IntermediateParser.inc warning : bad md5sum for file /export/dredox1/devel_server/php/lib/php/phpDocumentor/phpDocumentor/Io.inc warning : bad md5sum for file /export/dredox1/devel_server/php/lib/php/phpDocumentor/phpDocumentor/LinkClasses.inc warning : bad md5sum for file /export/dredox1/devel_server/php/lib/php/phpDocumentor/phpDocumentor/PackagePageElements.inc failed to write /export/dredox1/devel_server/php/lib/php/phpDocumentor/phpDocumentor/Converters/CHM/default/templates/default/templates/.tmpbasicindex.tpl Seems like PEAR::Archive_Tar needs a fix badly. ------------------------------------------------------------------------ -- Edit this bug report at http://bugs.php.net/?id=21402&edit=1