Re: Math_Numbers and Numbers_Roman

--- Sterling Hughes <sterling@bumblebury.com> wrote: > I noticed how the directories were shaped, and I'm not sure how to > proceed with this package. > > The class itself is Numbers_Roman, it is installed as Numbers/Roman.php, > however, it is in Math_Numbers (which is wrong, imho, numbers are not a > subset of math). Agree there. Numbers_Roman sounds like a plan. Although the idea of putting them under a Format dir/category is also sound. After all it is a representational class, not one that allows to do math in Roman numeral (which might be fun to make). > I would prefer not renaming it, as it is pretty widely > used, but rather renaming Math_Numbers to Numbers. > > The other option (that I see), is renaming the class to > Math_Numbers_Roman and then placing a small container: > > class Numbers_Roman extends Math_Numbers_Roman { > } > > But I'd prefer not to do that. Being that (a) you are going to have the package installing in Numbers/Roman.php (in the version I got locally the package.xml points to Math/Roman.php) (b) The name of the class is Numbers_Roman (c) What exact dir it resides in PEAR's CVS tree is not too critical (from the user point of view) I would say, go ahead with the renaming/move/package.xml. You might also want to add some info in the new release to indicate 'Math/Roman.php' is deprecated and people should be using 'Numbers/Roman.php' instead. Maybe an indication to use "pear uninstall Numbers_Roman; pear install Numbers_Roman" for a new release (rather than update, as I am not sure update is smart enough to remove files in prev locations) ===== --- Jesus M. Castagnetto (jcastagnetto@yahoo.com) Research: http://metallo.scripps.edu/ Personal: http://www.castagnetto.org/ __________________________________________________ Do you Yahoo!? Yahoo! Mail Plus - Powerful. Affordable. Sign up now. http://mailplus.yahoo.com