Validate: problems, suggestion, RFC
| From: | Bertrand Mansion | Date: | Mon, 17 Feb 2003 12:28:33 +0000 |
| Subject: | Validate: problems, suggestion, RFC | ||
| Groups: | php.pear.dev | ||
| Request: | Send a blank email to pear-dev+get-13405@lists.php.net to get a copy of this message | ||
Hi Pierre, Damien,
I have made some CS changes to the Validate package as you might have
noticed in CVS. Hope you didn't mind...
After a few tests using Validate with QuickForm, I think it might be a good
thing to split some method into smaller chunks. For instance, the
Validate::number() could call two other methods: Validate::numberFormat()
and Validate::numberMinMax(). This would give more control on the error and
why the number didn't pass the test. In terms of feedback to the user,
that's better.
I tested the ISBN validation but it didn't work with my entry :
0-7851-0853-X (a Richard Corben Marvel comics...)
This entry works with http://www.isbn.nu so that might be a bug.
Apart from these problems, everything else in Validate.php seems to work as
expected with QuickForm.
Bertrand Mansion
Mamasam