toArray() behaviour (was: Re: [PEAR-DEV] Re: QuickForm 3.0 news: renderers)

Thomas Schulz wrote:

toArray() works through a new renderer as well, although its behaviour changed a bit: it does not return html for group elements, but rather an array of group elements' array representations. BTW, I need feedback from toArray() users: is this BC break OK with them or should I add a BC switch?

For me it's OK, because I wait for these behavior to have a cleaner way to use toArray() with Smarty. Some feedback after I get the current CVS-version and look at the toArray()-output of QuickForm_example.php: The special handling of "non-grouped" radio buttons looks not good for me. How about numeric keys for all elements to avoid name conflicts?

I just copied the behaviour of the old toArray() method, trying to break as little as possible. :] But I think that yours is a good idea. For currently if you do $form->addElement('radio', 'foo', ...); $form->addElement('text', 'bar', ...); $form->addElement('radio', 'foo', ...); then the radios will be grouped together in array, while they will be rendered with a text input between them using other renderers. Moving to numeric keys instead of element names in array will fix this situation indeed. Any more feedback from toArray() users?