Re: QuickForm Patch
| From: | Jon Wood | Date: | Sun, 20 Apr 2003 22:27:08 +0000 |
| Subject: | Re: QuickForm Patch | ||
| References: | 1 2 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-15268@lists.php.net to get a copy of this message | ||
On Sun, 2003-04-20 at 18:48, Alexey Borzov wrote:
> Greetings!
>
> Jon Wood wrote:
> > After making a complete mess of submitting this the other day, I thought
> > I'd submit it again.
> >
> > This adds a setElementDescription method to the main QuickForm class to
> > add some instructional text to an element, and adds setValue to the
> > static elements so they can be swapped with other elements.
>
> Well, while I see that this feature can be useful sometimes, I must say that I
> do not agree with its implementation.
>
> These 'descriptions' are just special cases of element 'labels' and adding
> new
> infrastructure to display them that is completely *incompatible* with labels is
> a bad idea.
>
> Maybe just add a possibility for labels to be arrays and when they are arrays
> assign them to {label1}, {label2}, ... {labelN} placeholders?
>
Ok, I'll take a look at that, I'm not very familiar with the QuickForm
code, so that seemed like the best solution at the time.
If there's no problem with adding setValue to the static element I'd
appreciate it if that could be merged in though, since I really don't
want to maintain a fork of QuickForm just for that.
Jon