#23983 [Opn->Csd]: whereAdd($keywords); accepts blank $keywords

ID: 23983 Updated by: alan_k@php.net Reported By: mike dot carter at koa dot uk dot com -Status: Open +Status: Closed Bug Type: PEAR related Operating System: Windows XP PHP Version: 4.3.1 New Comment: This bug has been fixed in CVS. In case this was a PHP problem, snapshots of the sources are packaged every three hours; this change will be in the next snapshot. You can grab the snapshot at http://snaps.php.net/. In case this was a documentation problem, the fix will show up soon at http://www.php.net/manual/. In case this was a PHP.net website problem, the change will show up on the PHP.net site and on the mirror sites in short time. Thank you for the report, and for helping us make PHP better. have added checks to orderby/limit etc. as well. Thanks, Regards Alan Previous Comments: ------------------------------------------------------------------------ [2003-06-03 08:56:30] mike dot carter at koa dot uk dot com If I try to do a $dobj->whereAdd($keywords); and $keywords is empty/null then surely DataObjects would be best off just ignoring the request and disgarding it? Instead it adds an additional "AND" into the query string being built causing an invalid SQL query. ------------------------------------------------------------------------ -- Edit this bug report at http://bugs.php.net/?id=23983&edit=1