#23917 [Opn->Bgs]: PEAR_Common::analyzeSourceCode uses token_get_all on non-php files

ID: 23917 Updated by: pajoye@php.net Reported By: greg at chiaraquartet dot net -Status: Open +Status: Bogus Bug Type: PEAR related Operating System: Windows XP PHP Version: 4.3.2 New Comment: <the PEAR_Frontend_Web package has .png files as role="php".> I know and that will change soon :). <I'm sure there are other packages that have this situation. > yes, and there is absolutely no reason to do so ;). Well actually pear does have a way to install client side files. This is not a reason to mis-use the installation tree. <This is a bug that does need to be fixed> So keep it closed. <I think you either need to check the file extension (easy solution) or rework the role attribute so that it can handle special cases such as images that must be in the document root.> this is in the todo <I don't know a good solution to this if the file extension isn't checked.> We cannot rely only on file extension, imho. please keep this bug report closed, as it is not a bug. feel free to discuss a solution about "client" side installation on peardev. But about data, there is role="data". Now every well installed installation should have the correct ENV vars, then you can get the data folder quickly. thank's for your report, pierre Previous Comments: ------------------------------------------------------------------------ [2003-06-08 17:33:27] greg at chiaraquartet dot net check out http://cvs.php.net/co.php/pear/PEAR_Frontend_Web/package.xml?login=2&r=1.12 the PEAR_Frontend_Web package has .png files as role="php" I'm sure there are other packages that have this situation. This is a bug that does need to be fixed, I think you either need to check the file extension (easy solution) or rework the role attribute so that it can handle special cases such as images that must be in the document root. I don't know a good solution to this if the file extension isn't checked. Greg ------------------------------------------------------------------------ [2003-06-03 12:22:05] pajoye@php.net Sorry, but your problem does not imply a bug in PHP itself. For a list of more appropriate places to ask for help using PHP, please visit http://www.php.net/support.php as this bug system is not the appropriate forum for asking support questions. Thank you for your interest in PHP. <PEAR assumes that files with role="php" are PHP files,> Hmm, and what do you suggest? Binary datas should be in a specific data folder, and PEAR has a specific role for that with role="data". That makes sources tree much cleaner. However, I understand your problem while working with non pear user or with people that uses phpdocu from the uncompressed archive. Let find a suitable solution. pierre ------------------------------------------------------------------------ [2003-05-30 23:31:21] greg at chiaraquartet dot net PEAR assumes that files with role="php" are PHP files, but image files are included as part of docbuilder, and are parsed as PHP. Perhaps a basic extension check would fix this. This bug renders pear package impossible on phpDocumentor ------------------------------------------------------------------------ -- Edit this bug report at http://bugs.php.net/?id=23917&edit=1