Fix for PHPUnit SetupDecorator
| From: | Lorenzo Alberton | Date: | Mon, 09 Jun 2003 16:52:39 +0000 |
| Subject: | Fix for PHPUnit SetupDecorator | ||
| Groups: | php.pear.dev | ||
| Request: | Send a blank email to pear-dev+get-17213@lists.php.net to get a copy of this message | ||
Hi,
I found a bug in PHPUnit/GUI/SetupDecorator.php (current CVS), LINE 124:
====================================================
$className = str_replace('/','_',substr(str_replace($rootDir,'',$filename),1));
====================================================
should be
====================================================
$className = str_replace(DIRECTORY_SEPARATOR,'_',substr(str_replace($rootDir,'',$filename),1));
====================================================
otherwise the replacement is not honored under windows,
and the classname is wrong if it's different from filename.
Should I commit the fix to CVS?
HTH
Best regards,
Lorenzo