Re: [PATCH] wrong arguments in sybaseRaiseError()

# cox@idecnet.com / 2003-06-10 06:04:13 +0200: > From: "Roman Neuhauser" <neuhauser@bellavista.cz> > > # mj@php.net / 2003-06-09 18:53:13 +0200: > > > On Mon Jun 09, 2003 at 06:0737PM +0200, Roman Neuhauser wrote: > > > > sybaseRaiseError() calls raiseError() with wrong arguments: > > > > $error['code'] and $error['message'] are swapped. > > > > > > > > note that there are other issues with sybaseRaiseError() and error > > > > handling in DB::sybase in general, but I'm leaving them for later. > > > > > > Commited. You should really apply for CVS karma now :-). > > > > I've mailed group@. > > Please, do not forget to pass the PEAR DB tests before each commit, at least > the driver battery. For doing it's as easy as: > > # cd tests/driver > # joe setup.inc (set up the dsn for the database to test) > # pear run-tests . > > I've added to the STATUS doc the tests passed in the backends I'm trying, > that should still work after each commit. > > Feel free testers to send the results of the tests in the other DBs. This > will be a nice guide for developers to know what features will work in the > same way when porting (or using) his app to other database. Tomas, I wouldn't try to commit anything beyond trivial fixes like this one, and it is my intention to post my patches here before they go in cvs just like I've been doing. What I want to know is whether running the test suite will be any good in case of drivers for backends I don't access to. I have larger patches in the pipeline, but I do *not* intend to commit anything without testing: I'll be sending the patches to the list, and to the individual driver maintainers/testers, and only commit when/if they're approved. -- If you cc me or remove the list(s) completely I'll most likely ignore your message. see http://www.eyrie.org./~eagle/faqs/questions.html