#24166 [Fbk->Opn]: pear makerpm is broken

ID: 24166 Updated by: cox@php.net Reported By: jmcastagnetto@php.net -Status: Feedback +Status: Open Bug Type: PEAR related Operating System: Suse Linux 8.2 PHP Version: 4.3.2 -Assigned To: +Assigned To: cox New Comment: I'll change the way to unpack/install files. Let me some time to test it better. Previous Comments: ------------------------------------------------------------------------ [2003-06-15 11:32:08] cox@php.net Sorry, I commited a wrong version of my original patch, was a casuality to have a package.xml in my current dir, that's why it worked for me :-/ Btw, I've made a new file list, using the RPM vars. I haven't built rpms since many time, perhaps it's not correct. Could you test it? Thanks! ------------------------------------------------------------------------ [2003-06-15 01:10:47] jmcastagnetto@php.net The patch did not work. The one below does: --- Package.php-orig 2003-06-14 18:27:24.000000000 -0700 +++ Package.php 2003-06-14 18:26:37.000000000 -0700 @@ -585,7 +585,7 @@ $pkgdir = "$info[package]-$info[version]"; $info['rpm_xml_dir'] = '/var/lib/pear'; $this->config->set('verbose', $tmp); - if (!$tar->extractList("$pkgdir/package.xml", $instroot, $pkgdir)) { + if (!$tar->extractList("package.xml", $instroot)) { return $this->raiseError("failed to extract $params[0]"); } if (!file_exists("$instroot/package.xml")) { Also, the spec file might need some more work. The files end up being installed on a place highly dependent on the config of the person generating the RPM, For example. I have PHP installed in '/home/server/php', but most people have it in '/usr/local'. The postinstall part does not seem to be working. No matter what the local config is (tried on a machine where PHP is installed in /usr/local), and the RPM still tried to install it in '/home/server/php'. That is not the correct behaviour. Re-openning as this command still generates something the is (albeit indirectly) broken. I think that the '@doc_dir@' and '@files@' vars in the 'template.spec' might need to be reworked to generate a good non-pacakager-system dependent RPM. ------------------------------------------------------------------------ [2003-06-14 11:58:16] cox@php.net Oops, there was a conflict with my patch that I overpassed, it's commited now. The affected file is php4/pear/PEAR/Command/Package.php Thanks again :-) ------------------------------------------------------------------------ [2003-06-13 18:37:11] jmcastagnetto@php.net What file was changed? I do not see any commits to pear/Archive_Tar or the php4/pear/PEAR/? I am asking because I would like to test this functionality ;-) ------------------------------------------------------------------------ [2003-06-13 04:09:34] cox@php.net Fixed in CVS, Jesus. ------------------------------------------------------------------------ The remainder of the comments for this report are too long. To view the rest of the comments, please view the bug report online at http://bugs.php.net/24166 -- Edit this bug report at http://bugs.php.net/?id=24166&edit=1