#23930 [Asn->Csd]: PEAR_Packager::package can't handle filenames with spaces in the path

ID: 23930 Updated by: vblavet@php.net Reported By: greg at chiaraquartet dot net -Status: Assigned +Status: Closed Bug Type: PEAR related Operating System: Windows XP PHP Version: 4.3.2 Assigned To: vblavet New Comment: This bug has been fixed in CVS. In case this was a PHP problem, snapshots of the sources are packaged every three hours; this change will be in the next snapshot. You can grab the snapshot at http://snaps.php.net/. In case this was a documentation problem, the fix will show up soon at http://www.php.net/manual/. In case this was a PHP.net website problem, the change will show up on the PHP.net site and on the mirror sites in short time. Thank you for the report, and for helping us make PHP better. Added a new attribute in Archive_Tar to change the separator while adding several files in a single char string. This attribute must be set with the new method setAttribute(). The default separator remains ' ' for backward Compatibility. Sample : $archive->setAttribute(ARCHIVE_TAR_ATT_SEPARATOR, ','); Previous Comments: ------------------------------------------------------------------------ [2003-06-02 16:06:01] greg at chiaraquartet dot net Vincent, It's always nice when everyone can be correct :) I did a full-text search for createModify, and it is used in PEAR_Packager::package() on line 138 of Packager.php. All one needs to do is add an array() around $newpkgfile in: $ok = $tar->createModify($newpkgfile, '', $tmpdir); to get: $ok = $tar->createModify(array($newpkgfile), '', $tmpdir); In addition (and this is minor), I would suggest changing the PHPDoc @param for createModify() (which is by the way extremely useful and well-written, a pleasure to read). instead of @param string <description> try @param string|array <description>, this will allow people glancing at it to figure out what the exact types allowed are. Otherwise, I'm changing this bug's summary to match what is really going on. ------------------------------------------------------------------------ [2003-06-02 15:37:16] vblavet@php.net Greg, 'et', Both of you are right ! The use of blank space for file separation was really not a good idea, but it is now historical, and for compatibility reason we should keep it like that. Archive_Tar is working "as designed" and documented, and like stated by 'et' the best solution is to use an array to pass the file name. I will explore the available solutions. I would prefer a new method like set(attribute_name, value) to fix the separator for those you want to. We can also detect windows OS and do some specific tricks ... to invent. I will also try to find where in the PEAR package engine we are using these methods to improve the call by using arrays. Any suggestion is welcomed. ------------------------------------------------------------------------ [2003-06-01 01:28:19] et@php.net Actually, that is almost what it is doing. It accepts a string (space-delimited) or an array of path/filenames. So, if you have something that contains spaces, all you have to do is put them into an array. $foo->createModify(array('path/with spaces/to/file')); I suggest leaving it as-is, because it would break BC otherwise. Quoting/escaping would be nice, but is not really neccessary, i think. One easy thing that one could do though is introducing a 5th parameter (optional) specifying the delimiter for the filelist, defaulting to a space. Assigning this to the maintainer, he should decide what do to. ------------------------------------------------------------------------ [2003-05-31 20:24:19] greg at chiaraquartet dot net perhaps the best solution is to allow either a string (single filename) or an array of strings (multiple filenames) ------------------------------------------------------------------------ [2003-05-31 18:34:08] et@php.net et@edea:/tmp/foo$ touch foo\:bar et@edea:/tmp/foo$ touch foo\;bar et@edea:/tmp/foo$ ls foo:bar foo;bar ; and : are perfectly allowable characters, just like a space. the solution would rather be to a) quote the filenames and b) allow escaping of characters, but that is not a simple thing to do. ------------------------------------------------------------------------ The remainder of the comments for this report are too long. To view the rest of the comments, please view the bug report online at http://bugs.php.net/23930 -- Edit this bug report at http://bugs.php.net/?id=23930&edit=1