Re: Auth.php issues continued.....

Hello Alan, I believe changing the error message is a good thing, I'll do it as soon as an issue with my account is resolved. i also believe that auth should be in the root pear folder, but there should be a lot of apps out there using it from it's Auth/Auth.php location, removing it would definatelly break bc. we could put it in both places PEAR/Auth.php and PEAR/Auth/Auth.php remove it from the Auth folder sometimes in the future if nobody disagrees with this polution :) as for the containers, I think it should be easy to modify all of the to use an array if one is passed, thus retaining bc, I'll have a look into it soon Regards Yavor ----- Original Message ----- From: "Alan Knowles" <alan@akbkhome.com> To: "Alan Knowles" <alan@akbkhome.com> Cc: "Pear Announce" <pear-dev@lists.php.net> Sent: Thursday, July 10, 2003 5:21 AM Subject: Re: [PEAR-DEV] Auth.php issues continued..... > > function Auth_Container_File($filename) > { > if (!is_file($filename)) { > return PEAR::raiseError("Illegal filename.", 41, > PEAR_ERROR_DIE); > } > > Any chance changing that to: > > PEAR::raiseError("Auth_Containter_File:: file '$filename' is not a valid > filename, 41, PEAR_ERROR_DIE") > > > Regards > Alan > > > Alan Knowles wrote: > > Just having a go integratating pear auth into my little framework, I > > notice a few oddities.. > > > > A) > > <file role="php" baseinstalldir="Auth" > > name="Auth.php"/> > > > > is installing Auth into Auth/Auth.php - I thought the standard for this > > was to stick it in the top level directory. > > > > B) contructors > > $auth = new Auth('File','filename'); > > $auth = new Auth('DB',array(..dsn..)) > > $auth = new Auth('DB','...dsn..') > > $auth = new Auth('SOAP',array(...lots of stuff..)) > > > > Would it be posible to standardize on new Auth($driver,$assocativeArray) > > to work on all drivers? - it makes writing config code for it alot easier.. > > > > Regards > > Alan > > > > > > > > > > > -- > Can you help out? > Need Consulting Services or Know of a Job? > http://www.akbkhome.com > > > -- > PEAR Development Mailing List (http://pear.php.net/) > To unsubscribe, visit: http://www.php.net/unsub.php > >