Re: XML_Tree previous patches/commits lost
| From: | Tomas V.V.Cox | Date: | Fri, 11 Jul 2003 01:02:07 +0000 |
| Subject: | Re: XML_Tree previous patches/commits lost | ||
| References: | 1 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-18148@lists.php.net to get a copy of this message | ||
On Friday, July 11, 2003 1:51, Blair Robertson wrote:
> Gday,
> I just noticed that there have been a couple of commits to XML_Tree in
> the past few days, and that they have undone some previous patches that
> were submitted.
> I am pretty sure that this is to do with the patch/changes made by
> Michele - which, don't get me wrong, is some nice work - that were made
> to the released version of XML_Tree, not the version in CVS.
> See
> http://marc.theaimsgroup.com/?l=pear-dev&m=105758205602071&w=2
> for
> the email.
> This is potentially a big issue with the way that patches are submitted
> and committed - but I can't come up with a solution other than diligence
> by the person that does the commiting.
He sent me just the files modified of an old
version, so I needed to extract a patch, do lots of cosmetic changes
plus taking care on don't overwrite anything. The patch was very big
and I missed the things you mention. It's my fault accepting that
instead of a clean diff against lastest cvs.
Anyways, I've haven't upload a new release, just commited for people
like you to test it.
> Anyway, I have attached two patches to bring re-apply the changes
Applied, thanks for noticing,
--
Tomas V.V.Cox mailto:cox@idecnet.com